Closed
Bug 1167291
Opened 10 years ago
Closed 10 years ago
Expand the cross-compartment checks we do during marking
Categories
(Core :: JavaScript: GC, defect)
Core
JavaScript: GC
Tracking
()
RESOLVED
FIXED
mozilla41
Tracking | Status | |
---|---|---|
firefox41 | --- | fixed |
People
(Reporter: terrence, Assigned: terrence)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
patch
|
jonco
:
review+
|
Details | Diff | Splinter Review |
I'm a bit annoyed to need maybeCompartment, since we should be able to statically determine if there is a compartment method on T. Unfortunately the tricks I used to capture this were universally longer or more complicated than this approach, or crashed gcc, clang, or gdb. On the other hand, this approach does let us effectively remove the MaybeCompartment method in jsgc.cpp. That patch is a bit lower in my queue, but does make this approach end up paying for itself pretty handily.
Attachment #8608888 -
Flags: review?(jcoppeard)
Updated•10 years ago
|
Attachment #8608888 -
Flags: review?(jcoppeard) → review+
Assignee | ||
Comment 1•10 years ago
|
||
Comment 3•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in
before you can comment on or make changes to this bug.
Description
•