Closed
Bug 1167292
Opened 10 years ago
Closed 9 years ago
Add telemetry for heap snapshots
Categories
(DevTools :: Memory, defect)
DevTools
Memory
Tracking
(firefox42 fixed)
RESOLVED
FIXED
Firefox 42
| Tracking | Status | |
|---|---|---|
| firefox42 | --- | fixed |
People
(Reporter: fitzgen, Assigned: fitzgen)
References
(Blocks 1 open bug)
Details
Attachments
(3 files, 2 obsolete files)
|
(deleted),
patch
|
ejpbruel
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
ejpbruel
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
fitzgen
:
review+
|
Details | Diff | Splinter Review |
* Time to take a snapshot
* Number of nodes in the heap graph
* Number of edges in the heap graph
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → nfitzgerald
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•9 years ago
|
||
|
|
Assignee | |
Comment 2•9 years ago
|
||
|
|
Assignee | |
Comment 3•9 years ago
|
||
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8617006 -
Flags: review?(jimb)
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8617007 -
Flags: review?(jimb)
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8617008 -
Flags: review?(jimb)
|
|
Assignee | |
Comment 4•9 years ago
|
||
Attachment #8617008 -
Attachment is obsolete: true
Attachment #8617008 -
Flags: review?(jimb)
|
|
Assignee | |
Comment 5•9 years ago
|
||
Comment on attachment 8617014 [details] [diff] [review]
Part 3: Add telemetry probes for node and edge counts when saving heap snapshots
Updated the max values these new histograms can accept after I did some tests with various tabs open.
Attachment #8617014 -
Flags: review?(jimb)
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8617006 -
Flags: review?(jimb) → review?(ejpbruel)
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8617007 -
Flags: review?(jimb) → review?(ejpbruel)
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8617014 -
Flags: review?(jimb) → review?(ejpbruel)
|
||
Updated•9 years ago
|
Attachment #8617006 -
Flags: review?(ejpbruel) → review+
|
|
||
Updated•9 years ago
|
Attachment #8617007 -
Flags: review?(ejpbruel) → review+
|
|
||
Comment 6•9 years ago
|
||
Comment on attachment 8617014 [details] [diff] [review]
Part 3: Add telemetry probes for node and edge counts when saving heap snapshots
Review of attachment 8617014 [details] [diff] [review]:
-----------------------------------------------------------------
Trivial patches, so not much to add.
Attachment #8617014 -
Flags: review?(ejpbruel) → review+
|
||
Comment 8•9 years ago
|
||
Backed out for red desktop hazard build, see http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-inbound-linux64-br-haz/20150720171028/hazards.txt.gz for details.
https://hg.mozilla.org/integration/mozilla-inbound/rev/859165225d9d
|
|
Assignee | |
Comment 9•9 years ago
|
||
Attachment #8617014 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 10•9 years ago
|
||
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8636622 -
Flags: review+
|
||
Comment 11•9 years ago
|
||
|
||
Comment 12•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/79d34da55497
https://hg.mozilla.org/mozilla-central/rev/7a271450a908
https://hg.mozilla.org/mozilla-central/rev/112fb27a265c
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox42:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•