Closed
Bug 1167344
Opened 10 years ago
Closed 10 years ago
[Add-on Manager][Settings] Need to pass a 'manifestURL' option to section:addons MozActivity
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: justindarc, Assigned: yzen)
References
Details
(Whiteboard: [spark])
Attachments
(1 file)
In the MozActivity for displaying the Add-on Manager (the screen listing all installed add-ons), we need to be able to pass a `manifestURL` option that filters the listing to only show add-ons that affect the app with the provided `manifestURL`.
Reporter | ||
Updated•10 years ago
|
Comment 1•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Attachment #8610803 -
Flags: review?(arthur.chen)
Comment 2•10 years ago
|
||
Comment on attachment 8610803 [details]
[gaia] yzen:bug-1167344 > mozilla-b2g:master
Thanks for the patch, yura.
My suggestion on the patch is implementing the filter outside of AddonManager. That would give us more flexibility on supporting possible use cases in the future.
Regarding the filter itself, for this time being there is no way to set a filter directly on an observable array (I should add this part :p), but you can observe the changes from addons#AddonManager and update another observable array that is bound to the list view. addons_list.js seems a good place for setting these things up.
Attachment #8610803 -
Flags: review?(arthur.chen)
Assignee | ||
Comment 3•10 years ago
|
||
Comment on attachment 8610803 [details]
[gaia] yzen:bug-1167344 > mozilla-b2g:master
Hopefully looks better now, thanks!
Attachment #8610803 -
Flags: review?(arthur.chen)
Comment 4•10 years ago
|
||
Comment on attachment 8610803 [details]
[gaia] yzen:bug-1167344 > mozilla-b2g:master
r=me with the last comment addressed, thanks!
Attachment #8610803 -
Flags: review?(arthur.chen) → review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Updated•10 years ago
|
Keywords: checkin-needed
Comment 5•10 years ago
|
||
https://github.com/mozilla-b2g/gaia/pull/30246
Autolander could not land the pull request due to not having collaborator rights. This is possibly due to a tree closure. Please check the tree status and request checkin again once the tree is open.
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 6•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•