Closed Bug 1167502 Opened 10 years ago Closed 10 years ago

Use TabStateFlusher.flush() instead of sync flushing in tests

Categories

(Firefox :: Session Restore, defect)

Product:
Firefox
Component:
Session Restore
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 41
Tracking Flags:
Tracking Status
firefox41 --- fixed

People

(Reporter: ttaubert, Assigned: ttaubert)

References

Details

Attachments

(3 files)

0001-Bug-1167502-Convert-CloudSync-test.patch
(deleted), patch
billm
: review+
Details | Diff | Splinter Review
0002-Bug-1167502-Convert-browser-base-content-test-genera.patch
(deleted), patch
billm
: review+
Details | Diff | Splinter Review
0003-Bug-1167502-Convert-sessionstore-tests.patch
(deleted), patch
billm
: review+
Details | Diff | Splinter Review
We can get rid of synchronous TabState.flush() calls in tests.
Attachment #8609194 - Flags: review?(wmccloskey)
Summary: Use TabStateFlusher in tests where possible → Use TabStateFlusher.flush() instead of sync flushing in tests
Attachment #8609196 - Flags: review?(wmccloskey)
Blocks: 1167508
Attachment #8609194 - Flags: review?(wmccloskey) → review+
Attachment #8609195 - Flags: review?(wmccloskey) → review+
Attachment #8609196 - Flags: review?(wmccloskey) → review+
Had to push a bustage fix because I somehow forgot to actually import the new JSM. I am sure though I ran the tests locally... whatever.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: