Closed
Bug 1167503
Opened 9 years ago
Closed 9 years ago
Remove |popPermissions| in dom/apps/tests/test_third_party_homescreen.html
Categories
(Core Graveyard :: DOM: Apps, defect)
Core Graveyard
DOM: Apps
Tracking
(firefox41 fixed)
RESOLVED
FIXED
mozilla41
Tracking | Status | |
---|---|---|
firefox41 | --- | fixed |
People
(Reporter: CuveeHsu, Assigned: mootoh)
References
Details
(Whiteboard: [good first bug])
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
Details | Diff | Splinter Review |
After Bug 1149868 lands, we need not to use |popPermissions| as a workaround in the test dom/apps/tests/test_third_party_homescreen.html. Just simply remove this two-lines chunk. https://dxr.mozilla.org/mozilla-central/source/dom/apps/tests/test_third_party_homescreen.html#178
Here is a quick patch for this, which looks too obvious though.
Reporter | ||
Comment 2•9 years ago
|
||
Since Bug 1149868 has landed, here's something you could do next: 1. Take this bug 2. Rebase and test again to make sure your patch work (locally test and/or push to try server) 3. Request a review to a module owner Enjoy!
Thanks :junior and :glob, I asked a commit access Level 1 in Bug 1168288 to test it on try server.
Tested the change on try server: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5002ae21d4bc It looks like it failed in browser/base/content/test/general/browser_popup_blocker.js, though I guess it is not related to this change.
Attachment #8610094 -
Flags: review?(fabrice)
Comment 5•9 years ago
|
||
Comment on attachment 8610094 [details] [diff] [review] 1167503.diff Review of attachment 8610094 [details] [diff] [review]: ----------------------------------------------------------------- Thanks, I re-triggered bc1 and it's green.
Attachment #8610094 -
Flags: review?(fabrice) → review+
Thanks Fabrice for the review. Now I think the steps :junior mentioned have been completed. What else I can do to land this?
Assignee: mootoh → juhsu
Comment 7•9 years ago
|
||
(In reply to mootoh from comment #6) > Thanks Fabrice for the review. > Now I think the steps :junior mentioned have been completed. What else I can > do to land this? You need to update your patch commit message to add r=fabrice, then you can set `checkin-needed` in the keyword field of the bug. Thanks for contributing!
Reporter | ||
Comment 8•9 years ago
|
||
Hello mootoh, If you need some information from somebody, you could use needinfo flag. Happy hacking!
Assignee: juhsu → mootoh
Updated the commit message of the patch to include the reviewer.
Attachment #8610094 -
Attachment is obsolete: true
Assignee | ||
Comment 10•9 years ago
|
||
Thanks Fabrice, the patch has been updated and I've just set the keyword as `checkin-needed`. Alright Junior, good to know that and I'll do it next.
Keywords: checkin-needed
Comment 11•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/cf6ccc2b40fd
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/cf6ccc2b40fd
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox41:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Updated•7 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•