Closed Bug 1167633 Opened 10 years ago Closed 9 years ago

Remove SpiderMonkey specific JS syntax from App Manager / WebIDE

Categories

(DevTools Graveyard :: WebIDE, defect)

Product:
DevTools Graveyard
Component:
WebIDE
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox41 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 41
Tracking Flags:
Tracking Status
firefox41 --- fixed

People

(Reporter: jryans, Assigned: jryans)

References

Details

Attachments

(1 file)

0001-Bug-1167633-Remove-SpiderMonkey-specific-JS-syntax-f.patch
(deleted), patch
pbro
: review+
Details | Diff | Splinter Review
From bug 887895: app-manager/content/projects.js:129:66 Unexpected identifier app-manager/test/browser_manifest_editor.js:16:20 Illegal yield expression webide/content/webide.js:195:17 Unexpected identifier webide/modules/app-manager.js:707:70 Unexpected identifier webide/modules/simulator-process.js:38:19 Unexpected token ! webide/test/browser_tabs.js:21:20 Illegal yield expression webide/test/browser_widget.js:8:20 Illegal yield expression webide/test/sidebars/browser_tabs.js:23:20 Illegal yield expression webide/webide-prefs.js:1:1 Unexpected token ILLEGAL
Assignee: nobody → jryans
Status: NEW → ASSIGNED
Comment on attachment 8609449 [details] [diff] [review] 0001-Bug-1167633-Remove-SpiderMonkey-specific-JS-syntax-f.patch Review of attachment 8609449 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for helping out J.Ryan, that looks good!
Attachment #8609449 - Flags: review?(pbrosset) → review+
https://hg.mozilla.org/mozilla-central/rev/fdd54aa88999
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox41: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
Product: Firefox → DevTools
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: