Closed
Bug 1167795
Opened 10 years ago
Closed 10 years ago
Remove DumpHeapVisitChild
Categories
(Core :: JavaScript: GC, defect)
Core
JavaScript: GC
Tracking
()
RESOLVED
FIXED
mozilla41
Tracking | Status | |
---|---|---|
firefox41 | --- | fixed |
People
(Reporter: terrence, Assigned: terrence)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
patch
|
mccr8
:
review+
|
Details | Diff | Splinter Review |
The only difference from DumpHeapVisitRoot is a prefix on the string. If we just pass an explicit prefix to print, we can skip having a second almost-identical function here and, more importantly, kill the last user of setTraceCallback.
We can't move to fully static dispatch because the tracing has to be out-of-line, but switching to virtual dispatch here would be nicer on the analysis and potentially faster in some cases.
Attachment #8609663 -
Flags: review?(continuation)
Comment 1•10 years ago
|
||
Comment on attachment 8609663 [details] [diff] [review]
remove_DumpHeapVisitChild-v0.diff
Review of attachment 8609663 [details] [diff] [review]:
-----------------------------------------------------------------
::: js/public/TracingAPI.h
@@ -133,5 @@
> contextName_(nullptr), contextIndex_(InvalidIndex), contextFunctor_(nullptr)
> {}
>
> - // Update the trace callback.
> - void setTraceCallback(JSTraceCallback traceCallback) {
Nice!
::: js/src/jsfriendapi.cpp
@@ +892,1 @@
> FILE* output;
Maybe get rid of this weird extra space before output while you are here.
@@ +968,1 @@
> DumpHeapVisitRoot(JS::CallbackTracer* trc, void** thingp, JS::TraceKind kind)
Please rename DumpHeapVisitRoot to something more generic. DumpHeapVisitGCThing or something?
Attachment #8609663 -
Flags: review?(continuation) → review+
Assignee | ||
Comment 2•10 years ago
|
||
Comment 4•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in
before you can comment on or make changes to this bug.
Description
•