[1.Description]: [Flame 3.0][DSDS][Message]While we send message or MO a call, check the "Select SIM" view. We can find "Dial 12345 via" is always displayed as heading. See attachment: logcat1.txt, video 1.mp4. Found at:15:16 [2.Testing Steps]: Precondition: Insert two SIM cards in device. 1.Launch message. 2.Tap New button. 3.Input a number ex:10010 4.Input some text in content box. 5.Long tap send button. [3.Expected Result]: 5."Select SIM" should be displayed as heading. [4.Actual Result]: 5.You can see "Dial 12345" via is displayed as heading. [5.Reproduction build]: Device:Flame 2.2[Unaffected] Build ID 20150524002504 Gaia Revision de5942bd99b801d4d04b676f1e70a77e93115d95 Gaia Date 2015-05-22 19:38:55 Gecko Revision https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/1bd024f4e171 Gecko Version 37.0 Device Name flame Firmware(Release) 4.4.2 Firmware(Incremental) eng.cltbld.20150524.040835 Firmware Date Sun May 24 04:08:46 EDT 2015 Bootloader L1TC000118D0 Device: Flame3.0[Affected] Build ID 20150524160204 Gaia Revision 5bcc08a732163087999251b523e3643db397412c Gaia Date 2015-05-24 14:44:40 Gecko Revision https://hg.mozilla.org/mozilla-central/rev/b6623a27fa64 Gecko Version 41.0a1 Device Name flame Firmware(Release) 4.4.2 Firmware(Incremental) eng.cltbld.20150524.192425 Firmware Date Sun May 24 19:24:36 EDT 2015 Bootloader L1TC000118D0 [6.Reproduction Frequency]: Always Recurrence,5/5 [7.TCID]: Free Test [8.Note] This issue also exists in dialer.

This is likely a regression of bug 1160110, because this is the only change to the gaia_sim_picker element for nearly 1 year :) Kevin, Doug, remember this element is used by the SMS app as well... Could you please have a look ?

[Blocking Requested - why for this release]:

Well it was already broken due to platform changes, but maybe we didn't fix it fully. I'm currently traveling and don't have a device with DSDS setup, but will investigate this when I get back.

Oops, leave needinfo so I can look later.

OK, I think I got the issue, I can prepare a patch. We manually add a data-l10n-id in getOrPick, I think we need to call translateFragment as well on this element. Note that the same issue happens in Dialer too: the header should reflect the phone number but doesn't.

Stas, would it make sense to at least extend our bindings to let people easily set our MO on their nodes (shadowDOM in this example)?

Comment on attachment 8610591 [details] [gaia] julienw:1168060-translate-after-l10nid > mozilla-b2g:master Hey Doug, Gandalf, I ask review from you both because of the history in Bug 1160110. There were several issues in that bug: * mozL10n.translateFragment(shadowRoot) doesn't work because translateFragment (currently) expects an element. Maybe this could be fixed in l10n.js (check that hasAttribute exists before calling it) but in the mean time I call translateFragment directly on the menu. * translateFragment was called only once when the component was created. This doesn't work because the list of SIMs is built at the first getOrPick call, and getOrPick itself changes the header. This kind of worked in Dialer because localizeDom was called as mozL10n.ready() callback (that internally uses setTimeout when it's already ready), and so the DOM could be generated before localizeDOM was called. But when displaying the menu once more for another phone number the header was not updated. So I fixed these and I also removed the mozL10n.ready() call as l10n.js does that already in translateFragment. I also added unit tests. Tell me what you think ! Gandalf, especially, tell me if you'd prefer that I fix l10n.js so that I can call translateFragment on the shadowRoot.

Comment on attachment 8610591 [details] [gaia] julienw:1168060-translate-after-l10nid > mozilla-b2g:master Stas would like that we fix l10n.js, I can try to do this then.

Comment on attachment 8610591 [details] [gaia] julienw:1168060-translate-after-l10nid > mozilla-b2g:master As :stas said in [1], the l10n failure is a bug so I fixed it (with unit tests) and now we call translateFragment on the shadowRoot. [1] https://github.com/mozilla-b2g/gaia/pull/30020#issuecomment-105534222

Comment on attachment 8610591 [details] [gaia] julienw:1168060-translate-after-l10nid > mozilla-b2g:master I left a question on the PR. Let's discuss that before I finish the review.

Comment on attachment 8610591 [details] [gaia] julienw:1168060-translate-after-l10nid > mozilla-b2g:master r+

OK Doug, I updated the PR; now the gaia_sim_picker change is a lot simpler :)

Comment on attachment 8610591 [details] [gaia] julienw:1168060-translate-after-l10nid > mozilla-b2g:master Looks good, thanks.

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/614525097bd3d5b473cd58a8bf4c560f82f0a5b7

L20n: https://github.com/l20n/l20n.js/commit/993a0f1b9e87de6595a0a611c2d4a4947c820d16

This bug has been verified as pass on latest build of Flame 3.0. Rate:0/5 Device: Flame 3.0[Verified] Build ID 20150531160203 Gaia Revision e6dc0f4c583407a4a52a66ce7cb11f058302a762 Gaia Date 2015-05-29 17:20:26 Gecko Revision https://hg.mozilla.org/mozilla-central/rev/f8d21278244b Gecko Version 41.0a1 Device Name flame Firmware(Release) 4.4.2 Firmware(Incremental) eng.cltbld.20150531.192324 Firmware Date Sun May 31 19:23:35 EDT 2015 Bootloader L1TC000118D0

(In reply to Zibi Braniecki [:gandalf][:zibi] from comment #7) > Stas, would it make sense to at least extend our bindings to let people > easily set our MO on their nodes (shadowDOM in this example)? In version 3.x and 4.x of l20n.js there's the document.l10n.observeRoot method which can be used for this purpose.