Closed Bug 1168135 Opened 9 years ago Closed 9 years ago

Cache API should share initial setup DB connection with following Actions

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla41
Tracking Flags:
Tracking Status
firefox41 --- fixed

People

(Reporter: bkelly, Assigned: bkelly)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

P1 Execute Cache init Action on same target thread used for other Actions. r=ehsan
(deleted), patch
ehsan.akhgari
: review+
Details | Diff | Splinter Review
P2 Add Cache Context::Init() method. r=ehsan
(deleted), patch
ehsan.akhgari
: review+
Details | Diff | Splinter Review
P3 Cache Context should pass shared Data container to init Action. r=ehsan
(deleted), patch
ehsan.akhgari
: review+
Details | Diff | Splinter Review
When I implemented bug 1134671 I allowed the sqlite DB connection to be shared between most Actions, but not the initial setup Action. The setup is run on the quota IO thread currently, so the connection could not be shared directly with the other actions. This should be fixed to minimize startup costs and also permit further optimizations. For example, I'd like to move certain database maintenance to the close of the DB connection, but I can't do that when we consistently open two connections.
Blocks: 1110458
Attachment #8610147 - Flags: review?(ehsan)
I'll finish reviewing this tomorrow...
Attachment #8610147 - Flags: review?(ehsan) → review+
Attachment #8610165 - Flags: review?(ehsan) → review+
Attachment #8610168 - Flags: review?(ehsan) → review+
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: