Open Bug 1168274 Opened 9 years ago Updated 2 years ago

Collapse all the resize events before fullscreen to the last one

Categories

(Core :: DOM: Events, enhancement, P5)

Product:
Core
Component:
DOM: Events
Type:
enhancement

Tracking

()

Tracking Flags:
Tracking Status
firefox41 --- affected

People

(Reporter: xidorn, Unassigned)

References

(Blocks 1 open bug)

Details

(Keywords: parity-chrome)

Attachments

(1 file)

patch 1 - avoid reflow for hiding window marigns on Windows
(deleted), patch
jimm
: review+
Details | Diff | Splinter Review
Currently, we dispatch a bunch of resize event before entering fullscreen. We should collapse all of them and only dispatch the last one.
Summary: Reduce the resize event before fullscreen to one the last one → Collapse all the resize events before fullscreen to the last one
The resize events are from the change of chrome controls. We probably should prevent those changes to trigger resize event on content.
(In reply to Xidorn Quan [:xidorn] (UTC+12) from comment #1) > The resize events are from the change of chrome controls. We probably should > prevent those changes to trigger resize event on content. That sounds right.
Depends on: 1168705
Keywords: leave-open
Comment on attachment 8612584 [details] [diff] [review] patch 1 - avoid reflow for hiding window marigns on Windows Review of attachment 8612584 [details] [diff] [review]: ----------------------------------------------------------------- I didn't see much of a difference visually, seems fine though if it cuts down on event traffic during the transition.
Attachment #8612584 - Flags: review?(jmathies) → review+
(In reply to Jim Mathies [:jimm] from comment #4) > Comment on attachment 8612584 [details] [diff] [review] > patch 1 - avoid reflow for hiding window marigns on Windows > > Review of attachment 8612584 [details] [diff] [review]: > ----------------------------------------------------------------- > > I didn't see much of a difference visually, seems fine though if it cuts > down on event traffic during the transition. It removes one resize event on Windows according to my test :)
Mass bug change to replace various 'parity' whiteboard flags with the new canonical keywords. (See bug 1443764 comment 13.)
Keywords: parity-chrome
Whiteboard: [parity-blink]
Priority: -- → P5
The leave-open keyword is there and there is no activity for 6 months. :hsinyi, maybe it's time to close this bug?
Flags: needinfo?(htsai)
No.
Flags: needinfo?(htsai)

The leave-open keyword is there and there is no activity for 6 months.
:hsinyi, maybe it's time to close this bug?

Flags: needinfo?(htsai)
Type: defect → enhancement
Flags: needinfo?(htsai)

The leave-open keyword is there and there is no activity for 6 months.
:hsinyi, maybe it's time to close this bug?

Flags: needinfo?(htsai)

Looks valid bug to me.

Flags: needinfo?(htsai)

The leave-open keyword is there and there is no activity for 6 months.
:hsinyi, maybe it's time to close this bug?

Flags: needinfo?(htsai)

no

Flags: needinfo?(htsai)

The leave-open keyword is there and there is no activity for 6 months.
:jstutte, maybe it's time to close this bug?

Flags: needinfo?(jstutte)

The leave-open keyword is there and there is no activity for 6 months.
:jstutte, maybe it's time to close this bug?

Flags: needinfo?(jstutte)

Probably not.

Flags: needinfo?(jstutte)

The leave-open keyword is there and there is no activity for 6 months.
:hsinyi, maybe it's time to close this bug?

Flags: needinfo?(htsai)

If the leave-open keyword is what you are looking... then let's just remove it :)

Flags: needinfo?(htsai)
Keywords: leave-open
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: