Closed Bug 11684 Opened 25 years ago Closed 25 years ago

[infinite loop] bugs - nsTextEditor.cpp

Categories

(SeaMonkey :: General, defect, P3)

x86
Other
defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: jay, Assigned: akkzilla)

References

Details

Analysis of the code has determined possible infinite loop or problem in the code below. See bug http://bugzilla.mozilla.org/show_bug.cgi?id=11588 for more information nsTextEditor.cpp:1570: warning: unsigned value < 0 is always 0 nsTextEditor.cpp:1648: warning: unsigned value < 0 is always 0
Blocks: 11588
Status: NEW → ASSIGNED
nsTextEditor.cpp is no longer in the build, but nsHTMLEditor.cpp, where mWrapColumn moved, still has the problem that mWrapColumn is declared as unsigned but sometimes used as signed. I don't see the infinite loop (I'll look more closely later to make sure there isn't one) but there are definitely issues here to be addressed (and I'm surprised it didn't show up as a warning). Good catch, thanks for the report!
Target Milestone: M10
Fix (making mWrapColumn a signed int) will go in when the tree opens for M10.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
A fix has been checked in; we no longer keep mWrapColumn at all, but instead get it from the current style, so we know we won't get out of sync. Code level fix, QA should just go ahead and mark verified unless the submitter wants to verify it.
Status: RESOLVED → VERIFIED
Marking Verified per last comments
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.