Bug 1167608 is going to remove NotifyWaitingForResourcesStatusChanged() call from MediaOmxReader. It is better do same thing to MediaCodecReader.

This is a revert of attachment 861044 in Bug 1154194. AskMediaCodecAndWait() could wait forever, it is not good to use such function. But just reverting it caused video playback failure.

(In reply to Sotaro Ikeda [:sotaro] from comment #2) > > But just reverting it caused video playback failure. It is a regression of Bug 1132832.

It seems better to create a new bug to fix comment 2 and also for removing AskMediaCodecAndWait() from MediaCodecReader.

(In reply to Sotaro Ikeda [:sotaro] from comment #4) > It seems better to create a new bug to fix comment 2 and also for removing > AskMediaCodecAndWait() from MediaCodecReader. I changed my mind, I am going to handle it in this bug.

(In reply to Sotaro Ikeda [:sotaro] from comment #5) > (In reply to Sotaro Ikeda [:sotaro] from comment #4) > > It seems better to create a new bug to fix comment 2 and also for removing > > AskMediaCodecAndWait() from MediaCodecReader. > > I changed my mind, I am going to handle it in this bug. I changed my mind again. Bug 1168531 is going to fix MediaCodecReader video playback problems.

Fix RTST problem.

Comment on attachment 8611410 [details] [diff] [review] patch part 1 - Implement MediaCodecReader::AsyncReadMetadata() Review of attachment 8611410 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/media/omx/MediaCodecReader.cpp @@ +1315,4 @@ > } > > bool > MediaCodecReader::CreateMediaCodec(sp<ALooper>& aLooper, nit: This function name is very similar to CreateMediaCodecs(), just different by one letter 's'. It might be better to change one of them. Maybe this one could be called "CreateCodec".

(In reply to Blake Wu [:bwu][:blakewu] from comment #13) > nit: > This function name is very similar to CreateMediaCodecs(), just different by > one letter 's'. It might be better to change one of them. Maybe this one > could be called "CreateCodec". This function name is already used. I do not find enough reason to change in this bug.