Markus Stange [:mstange] Reporter
	Description • 9 years ago

Load the testcase from the URL field on a HiDPI screen with classic (non-overlay) scrollbars. The blue border should go around the whole box and be adjacent to the vertical page scrollbar.

With APZ, the right border hides under the scrollbar.

There is the comment about scrollbars having 1 CSS pixel = 1 device pixel somewhere, but that comment is just wrong. Scrollbars are subject to the UnscaledDevicePixelsPerCSSPixel scale, but not to page zoom.

	Kartikaya Gupta (email:kats@mozilla.staktrace.com) Assignee
	Comment 1 • 9 years ago

The 1 CSS pixel = 1 device pixel thing happens at 3 of the 4 call sites to nsLayoutUtils::ScrollbarAreaToExcludeFromCompositionBoundsFor. I'm not sure if the 4th call site (which is nsLayoutUtils::CalculateCompositionSizeForFrame) also needs adjusting since it keeps everything in app units.

	Kartikaya Gupta (email:kats@mozilla.staktrace.com) Assignee
	Comment 2 • 9 years ago

This should be fixed by bug 1187792 but I don't have a HiDPI OS X device to test it on.

	Botond Ballo [:botond]
	Comment 3 • 9 years ago

IIUC, it will be un-fixed if in the future we turn on pinch-zooming on OS X?

	Markus Stange [:mstange] Reporter
	Comment 4 • 9 years ago

Yeah, so I think we should leave this bug open. But it no longer needs to block bug 1178298.

	Kartikaya Gupta (email:kats@mozilla.staktrace.com) Assignee
	Comment 5 • 9 years ago

I'll make it block the wider apz-desktop bug though (at this point it's a catch-all for anything related to APZ on desktop).

	Kartikaya Gupta (email:kats@mozilla.staktrace.com) Assignee
	Comment 6 • 9 years ago

After the patch on bug 1189837 I'm not sure if anything else needs to be done here.

	Kartikaya Gupta (email:kats@mozilla.staktrace.com) Assignee
	Comment 7 • 9 years ago

tn pointed out in bug 1189837 comment 11 that I missed one of the places, so this finishes it off.

	Pulsebot
	Comment 8 • 9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/384766aad27e

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 9 • 9 years ago

https://hg.mozilla.org/mozilla-central/rev/384766aad27e