Closed
Bug 1168586
Opened 10 years ago
Closed 10 years ago
Coverity complains about AutoEnterOOMUnsafeRegion::oomAfter_ not being initialized
Categories
(Core :: JavaScript: GC, defect)
Core
JavaScript: GC
Tracking
()
RESOLVED
FIXED
mozilla41
| Tracking | Status | |
|---|---|---|
| firefox41 | --- | fixed |
People
(Reporter: mccr8, Assigned: jonco)
References
(Blocks 1 open bug)
Details
(Keywords: coverity, Whiteboard: [cid 1299630])
Attachments
(1 file)
|
(deleted),
patch
|
terrence
:
review+
|
Details | Diff | Splinter Review |
It complains about this, despite the fact that it is only accessed when oomEnabled_ is true. Maybe oomEnabled_ can be made const and then Coverity could figure out that it is only used when initialized?
|
||
Comment 1•10 years ago
|
||
Considering this is debug only code, can we just initialize it?
|
Assignee | |
Comment 2•10 years ago
|
||
I get this as a warning from gcc too:
js/src/jsgc.h:1422:57: warning: ‘oomUnsafeRegion.js::gc::AutoEnterOOMUnsafeRegion::oomAfter_’ may be used uninitialized in this function [-Wmaybe-uninitialized]
Assignee: nobody → jcoppeard
|
|
Assignee | |
Comment 3•10 years ago
|
||
Let's just initialize it.
Attachment #8612175 -
Flags: review?(terrence)
|
||
Updated•10 years ago
|
Attachment #8612175 -
Flags: review?(terrence) → review+
|
||
Comment 5•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
|
||
Updated•6 years ago
|
Blocks: coverity-analysis
You need to log in
before you can comment on or make changes to this bug.
Description
•