Closed
Bug 1168597
Opened 10 years ago
Closed 8 years ago
[e10s] hotkeys module uses shims
Categories
(Add-on SDK Graveyard :: General, defect, P1)
Add-on SDK Graveyard
General
Tracking
(e10s+)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
e10s | + | --- |
People
(Reporter: billm, Assigned: gkrizsanits)
References
Details
Reporter | ||
Updated•9 years ago
|
Reporter | ||
Updated•9 years ago
|
Flags: needinfo?(wmccloskey)
Updated•9 years ago
|
Priority: -- → P1
Reporter | ||
Updated•9 years ago
|
Flags: needinfo?(wmccloskey)
Reporter | ||
Comment 1•9 years ago
|
||
Maybe the first thing here is to check whether we actually need to use the shims for this module. You can do that by setting extensions.interposition.enabled to false in about:config and then testing an extension that uses hotkeys in e10s.
Comment 2•9 years ago
|
||
(In reply to Bill McCloskey (:billm) from comment #1)
> Maybe the first thing here is to check whether we actually need to use the
> shims for this module. You can do that by setting
> extensions.interposition.enabled to false in about:config and then testing
> an extension that uses hotkeys in e10s.
What does the extensions.interposition.enabled do?
Flags: needinfo?(wmccloskey)
Updated•9 years ago
|
Blocks: sdk/hotkeys
Reporter | ||
Comment 3•9 years ago
|
||
It turns off the shims globally. So if the hotkeys code still works when extensions.interposition.enabled is false, then we know that the shims aren't needed for hotkeys to work.
The shims can also be disabled for a particular add-on by setting multiprocessCompatible to true in the install manifest:
https://developer.mozilla.org/en-US/Add-ons/Install_Manifests
That would be another way to go.
Flags: needinfo?(wmccloskey)
Updated•9 years ago
|
Assignee: nobody → evold
Comment 4•9 years ago
|
||
LastPass causes the slow/halting of filling in text. I added this to LP's install.rdf:
<em:multiprocessCompatible>true</em:multiprocessCompatible>
It worked the first time I filled in some text but after that the problem appeared. Is the parameter correct? Did I add it in the right place?
Thanks.
Comment 5•9 years ago
|
||
LastPass slow text fill in has been fixed by the latest dev e10s build.
Assignee | ||
Comment 6•9 years ago
|
||
I've just tested this while I was looking for an SDK module that uses shims. This module seemed to work just fine with extensions.interposition.enabled set to false, so I'm closing this for now.
Assignee: evold → gkrizsanits
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → INVALID
Reporter | ||
Comment 7•9 years ago
|
||
Well, the bug here is to stop the module from using shims even if the add-on has shims enabled. So sort of bug 1167802 I guess.
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
Assignee | ||
Comment 9•8 years ago
|
||
This should be fixed by bug 1196975.
Status: REOPENED → RESOLVED
Closed: 9 years ago → 8 years ago
Flags: needinfo?(gkrizsanits)
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•