Closed
Bug 1168676
Opened 9 years ago
Closed 9 years ago
Don't intercept object/embed right now
Categories
(Core :: DOM: Service Workers, defect)
Core
DOM: Service Workers
Tracking
()
RESOLVED
FIXED
mozilla41
Tracking | Status | |
---|---|---|
firefox41 | --- | fixed |
People
(Reporter: nsm, Assigned: nsm, Mentored)
Details
(Whiteboard: [lang=c++])
Attachments
(1 file, 1 obsolete file)
The current spec ignores 'potential client requests'
http://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#on-fetch-request-algorithm
due to https://github.com/slightlyoff/ServiceWorker/issues/249
Gecko does allow interception.
Comment 1•9 years ago
|
||
This should require obtaining the nsIHttpChannelInternal interface from the channel that is created by HTMLEmbedElement and HTMLObjectElement and calling the ForceNoIntercept method.
Updated•9 years ago
|
Mentor: josh
Whiteboard: [lang=c++]
Assignee | ||
Comment 2•9 years ago
|
||
/r/9509 - Bug 1168676 - Switch off embed/object ServiceWorker interception. r=ehsan
Pull down this commit:
hg pull -r 684a932803c29c73eabc3f4843a628cdcbe261cb https://reviewboard-hg.mozilla.org/gecko/
Attachment #8611551 -
Flags: review?(ehsan)
Assignee | ||
Comment 3•9 years ago
|
||
Comment 4•9 years ago
|
||
https://reviewboard.mozilla.org/r/9507/#review8277
::: dom/workers/test/serviceworkers/fetch/context/index.html:244
(Diff revision 1)
> + return Promise.resolve().then(function() {
Nit: please move this to the beginning of the function.
Comment 5•9 years ago
|
||
Comment 6•9 years ago
|
||
Comment on attachment 8611551 [details]
MozReview Request: bz://1168676/nsm
I'm sorry, ReviewBoard keeps fighting me. :(
Attachment #8611551 -
Flags: review?(ehsan) → review+
Assignee | ||
Comment 7•9 years ago
|
||
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/e5effe06a77f for apparently causing lots of assertion failures:
https://treeherder.mozilla.org/logviewer.html#?job_id=10235886&repo=mozilla-inbound
Flags: needinfo?(nsm.nikhil)
All failing just like in the try push, apparently...
Assignee | ||
Comment 10•9 years ago
|
||
Comment 11•9 years ago
|
||
Assignee: nobody → nsm.nikhil
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox41:
--- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Assignee | ||
Updated•9 years ago
|
Flags: needinfo?(nsm.nikhil)
Assignee | ||
Comment 12•9 years ago
|
||
Attachment #8611551 -
Attachment is obsolete: true
Attachment #8620367 -
Flags: review+
Assignee | ||
Comment 13•9 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•