blinky Reporter
	Description • 9 years ago

The scrollbar for <select> appears on the right side with "direction: rtl".

Testcase https://dl.dropboxusercontent.com/u/95157096/85f61cf7/qyw6bj3bd7.html

Screenshot https://dl.dropboxusercontent.com/u/95157096/85f61cf7/hlcyzm4gmg.png

	Gingerbread Man
	Comment 1 • 9 years ago

Mozilla/5.0 (X11; Linux x86_64; rv:41.0) Gecko/20100101 Firefox/41.0
Build ID: 20150526030202

	George Wright (:gw280) (needinfo me!) Assignee
	Comment 2 • 9 years ago

Related to bug 1164099. I'm confused how we're rendering differently here.

	George Wright (:gw280) (needinfo me!) Assignee
	Comment 3 • 9 years ago

OK, it looks like we do actually honour the style=rtl on the select element itself. I thought that wasn't possible, but ok. Should be an easy fix.

	George Wright (:gw280) (needinfo me!) Assignee
	Comment 4 • 9 years ago

This fixes the issue, but there are some alignment issues with the testcase (it's mis-aligned in exactly the same way as LTR is). That will be fixed by bug 1177445.

I've verified this patch doesn't break bug 1164099.

	Mike Conley (:mconley) (:⚙️)
	Comment 5 • 9 years ago

Comment on attachment 8633262 [details] [diff] [review]
0001-Bug-1168691-Preserve-the-text-direction-for-the-sele.patch

Review of attachment 8633262 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/modules/SelectContentHelper.jsm
@@ +46,5 @@
>      this.global.sendAsyncMessage("Forms:ShowDropDown", {
>        rect: rect,
>        options: this._buildOptionList(),
> +      selectedIndex: this.element.selectedIndex,
> +      direction: this.element.ownerDocument.defaultView.getComputedStyle(this.element).getPropertyValue("direction")

We've already got another place in this module that computes direction.

Let's add a new method to SelectContentHelper, that takes an element, and returns its computed direction, and just use that in both places.

	George Wright (:gw280) (needinfo me!) Assignee
	Comment 6 • 9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/d4cf686c5815

	Carsten Book [:Tomcat]
	Comment 7 • 9 years ago

https://hg.mozilla.org/mozilla-central/rev/d4cf686c5815