Closed Bug 1168691 Opened 10 years ago Closed 9 years ago

[e10s] The scrollbar for <select> appears on the right side with "direction: rtl"

Categories

(Core :: Layout: Form Controls, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla42
Tracking Status
e10s m8+ ---
firefox42 --- fixed

People

(Reporter: over68, Assigned: gw280)

References

(Blocks 1 open bug, )

Details

(Keywords: reproducible, rtl, testcase)

Attachments

(1 file)

The scrollbar for <select> appears on the right side with "direction: rtl". Testcase https://dl.dropboxusercontent.com/u/95157096/85f61cf7/qyw6bj3bd7.html Screenshot https://dl.dropboxusercontent.com/u/95157096/85f61cf7/hlcyzm4gmg.png
Mozilla/5.0 (X11; Linux x86_64; rv:41.0) Gecko/20100101 Firefox/41.0 Build ID: 20150526030202
Blocks: e10s-select
Status: UNCONFIRMED → NEW
Component: Untriaged → Layout: Form Controls
Ever confirmed: true
OS: Windows 7 → All
Product: Firefox → Core
Hardware: x86_64 → All
Blocks: e10s
tracking-e10s: --- → ?
Related to bug 1164099. I'm confused how we're rendering differently here.
OK, it looks like we do actually honour the style=rtl on the select element itself. I thought that wasn't possible, but ok. Should be an easy fix.
Assignee: nobody → gwright
This fixes the issue, but there are some alignment issues with the testcase (it's mis-aligned in exactly the same way as LTR is). That will be fixed by bug 1177445. I've verified this patch doesn't break bug 1164099.
Attachment #8633262 - Flags: review?(mconley)
Comment on attachment 8633262 [details] [diff] [review] 0001-Bug-1168691-Preserve-the-text-direction-for-the-sele.patch Review of attachment 8633262 [details] [diff] [review]: ----------------------------------------------------------------- ::: toolkit/modules/SelectContentHelper.jsm @@ +46,5 @@ > this.global.sendAsyncMessage("Forms:ShowDropDown", { > rect: rect, > options: this._buildOptionList(), > + selectedIndex: this.element.selectedIndex, > + direction: this.element.ownerDocument.defaultView.getComputedStyle(this.element).getPropertyValue("direction") We've already got another place in this module that computes direction. Let's add a new method to SelectContentHelper, that takes an element, and returns its computed direction, and just use that in both places.
Attachment #8633262 - Flags: review?(mconley) → review+
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: