Closed Bug 1168720 Opened 9 years ago Closed 9 years ago

Remove use of test env var MOZ_NO_REPLACE_FALLBACK and associated tests that are covered by other tests

Categories

(Toolkit :: Application Update, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)

References

Details

Attachments

(1 file)

I've been planning on removing as much test specific code from the client binaries which is much simpler now that there is a test updater and tests that are already covered by other tests. The MOZ_NO_REPLACE_FALLBACK env var isn't needed and the tests that use this env var are for the most part already covered by other tests and with a few changes these tests can completely cover those tests. Patch coming up soon.
Comment on attachment 8611071 [details] [diff] [review] patch rev1 Removes 14 Windows only tests! :)
Note regarding the try run. I used --tag appupdate which causes the mochitest-other tests to report failure on treeherder due to there being multiple test suites and treeherder reporting failures if any of the test suites don't run any tests (see bug 1162355). I've looked at the logs and verified that all of the mochitest-other tests passed.
The Windows builds systems suffered an automation error so here is a Windows only try push https://treeherder.mozilla.org/#/jobs?repo=try&revision=ca2e72b8cc66
Yay again... this removes two tests that have been intermittent! Bug 1112284 and bug 1166989
Blocks: 1112284, 1166989
Comment on attachment 8611071 [details] [diff] [review] patch rev1 Try runs look great!
Attachment #8611071 - Flags: review?(spohl.mozilla.bugs)
Comment on attachment 8611071 [details] [diff] [review] patch rev1 Review of attachment 8611071 [details] [diff] [review]: ----------------------------------------------------------------- ::: toolkit/mozapps/update/tests/data/xpcshellUtilsAUS.js @@ +3374,5 @@ > * > * Command line arguments used when launching the application: > * -no-remote prevents shell integration from being affected by an existing > * application process. > + * -test-process-updates makes the application exits after being relaunched by nit: s/exits/exit/
Attachment #8611071 - Flags: review?(spohl.mozilla.bugs) → review+
Flags: in-testsuite+
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: