Closed Bug 1168766 Opened 9 years ago Closed 9 years ago

[RTL] Loop desktop conversation toolbar should have icons in the opposite direction in rtl mode

Categories

(Hello (Loop) :: Client, defect, P4)

Product:
Hello (Loop)
Component:
Client
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla43

People

(Reporter: standard8, Unassigned, Mentored)

References

Details

(Whiteboard: [lang=css][fixed by bug 1184559])

User Story

As someone who uses Firefox in a right-to-left language, I see the desktop conversation window toolbar buttons ordered as follows:

(edit context)    _blank space_   (screen share)(audio mute)(video mute)(leave room)
When running in rtl mode on desktop with the conversation window open, the leave room, video mute, audio mute and screen share buttons are not reversed as they should be.
I'm prepared to mentor this. The bits to look at are the .conversation-toolbar and .btn-screen-share-entry in browser/components/loop/content/shared/css/conversation.css. They need body[dir="rtl"] versions adding to them to adjust the left to right, and right to left etc. Note, that for the rtl versions we should add an additional constraint of .fx-embedded for now - there's more serious issues with the standalone UI, so we don't want to affect that as well. To help test and fix this bug, using the ui-showcase might be easiest, see https://wiki.mozilla.org/Loop/Development for more information.
Mentor: standard8
Rank: 45
Priority: -- → P4
Whiteboard: [lang=css]
Flags: firefox-backlog+
User Story: (updated)
This has been fixed by bug 1184559.
Status: NEW → RESOLVED
Closed: 9 years ago
Depends on: 1184559
Resolution: --- → FIXED
Whiteboard: [lang=css] → [lang=css][fixed by bug 1184559]
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.