Bug 1154115 changed the json file format for profile data.

What's this with regard to? Update which profile? Any additional information necessary for the dev tools team?

I believe this is about the profile.sh script in the B2G repository, with the relevant code here: https://github.com/mozilla-b2g/B2G/blob/master/scripts/profile-symbolicate.py Instructions for profile.sh are here: https://developer.mozilla.org/en-US/docs/Mozilla/Performance/Profiling_with_the_Built-in_Profiler#Profiling_Boot_to_Gecko_%28with_a_real_device%29 https://developer.mozilla.org/en-US/docs/Mozilla/Performance/Profiling_Tutorial

Also need to update: https://hg.mozilla.org/mozilla-central/file/f986e55c4e0b/tools/profiler/merge-profiles.py I'll take it if no one is working on this.

(In reply to Ting-Yu Chou [:ting] from comment #3) > Also need to update: > https://hg.mozilla.org/mozilla-central/file/f986e55c4e0b/tools/profiler/ > merge-profiles.py > > I'll take it if no one is working on this. Great! I have not started on anything yet. Shu pointed out the new format is documented in the ProfileEntry header [1]. I believe all we need to do is process the |stringTable| array. Also we'll want to maintain backwards compatibility (the meta.version was bumped from 2 to 3, so this is easy to detect). [1] https://dxr.mozilla.org/mozilla-central/source/tools/profiler/ProfileEntry.h#271-362

(In reply to Eric Rahm [:erahm] from comment #4) > I believe all we need to do is process the |stringTable| array. Also we'll > want to maintain backwards compatibility (the meta.version was bumped from 2 > to 3, so this is easy to detect). Thanks for reminding, I'll do it on Monday :)

(In reply to Eric Rahm [:erahm] from comment #4) > (In reply to Ting-Yu Chou [:ting] from comment #3) > > Also need to update: > > https://hg.mozilla.org/mozilla-central/file/f986e55c4e0b/tools/profiler/ > > merge-profiles.py > > > > I'll take it if no one is working on this. > > Great! I have not started on anything yet. Shu pointed out the new format is > documented in the ProfileEntry header [1]. > > I believe all we need to do is process the |stringTable| array. Also we'll > want to maintain backwards compatibility (the meta.version was bumped from 2 > to 3, so this is easy to detect). If all you care about is symbolication of 0xF00 address, then yeah, looks like stringTable is all you need. May speed it up too, since the table is of unique strings only.

Comment on attachment 8613467 [details] Part 2: Fix the script searching unresolved addresses to handle new profiler JSON format Looks good to me. I like the use of a generator (I didn't know about those when I wrote the original code)

Master: https://github.com/mozilla-b2g/B2G/commit/47113646d3d1692a267c248721bbd038895ff22a