Comment on attachment 8611451 [details] [gaia] zbraniecki:1169030-update-gallery-to-modern-l10n-api > mozilla-b2g:master Hi Punam, can you look at this patch? It's just a simple update to the API usage, removing mozL10n.get and mozL10n.once/ready uses.

Comment on attachment 8611451 [details] [gaia] zbraniecki:1169030-update-gallery-to-modern-l10n-api > mozilla-b2g:master Hi Zibi I tested attached patch with today's m-c build and failed to see group header and aria-label set for thumbnail images (See github). Please check if navigator.mozL10n.formatValue returned value is handled correctly or if I am missing something? Thanks!

Comment on attachment 8611451 [details] [gaia] zbraniecki:1169030-update-gallery-to-modern-l10n-api > mozilla-b2g:master Updated the patch and manually tested that aria-label is set and that group header is set.

Comment on attachment 8611451 [details] [gaia] zbraniecki:1169030-update-gallery-to-modern-l10n-api > mozilla-b2g:master Thanks Zibi for updating patch, it looks good and has my r+.

https://github.com/mozilla-b2g/gaia/pull/30269 Autolander could not land the pull request due to not having collaborator rights. This is possibly due to a tree closure. Please check the tree status and request checkin again once the tree is open.

http://docs.taskcluster.net/tools/task-graph-inspector/#zHhNVfQqThiQx9DX9QUeXQ The pull request failed to pass integration tests. It could not be landed, please try again.

c'mon autolander, let's be friends

http://docs.taskcluster.net/tools/task-graph-inspector/#-lup7HNORiSncrv9Z-17_w The pull request failed to pass integration tests. It could not be landed, please try again.

In master: https://github.com/mozilla-b2g/gaia/commit/7a96cf4a72a907e2c94ccaa319561f0fc560569b