Closed Bug 1169233 Opened 9 years ago Closed 9 years ago

[gtk3] Disabled menu items are not greyed out

Categories

(Core :: Widget: Gtk, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: glandium, Assigned: stransky)

References

Details

Attachments

(1 file)

For example, press Alt or F10 to open the menu from the menu bar, In "Edit", you should expect "Undo", "Redo", "Cut", "Copy" and "Delete" to be disabled in many cases. You can't select them, as expected, but they have the same text color as other menu items.
The corresponding CSS is: http://hg.mozilla.org/mozilla-central/file/baa9c64fea6f/toolkit/themes/linux/global/menu.css#l36 So GrayText resolves to the same as MenuText.
(In reply to Mike Hommey [:glandium] from comment #1) > The corresponding CSS is: > http://hg.mozilla.org/mozilla-central/file/baa9c64fea6f/toolkit/themes/linux/ > global/menu.css#l36 > > So GrayText resolves to the same as MenuText. So here we come: http://mxr.mozilla.org/mozilla-central/source/widget/gtk/nsLookAndFeel.cpp#244 244 case eColorID_graytext: // disabled text in windows, menus, etc. 245 case eColorID_inactivecaptiontext: // text in inactive window caption 246 gtk_style_context_get_color(mBackgroundStyle, 247 GTK_STATE_FLAG_INSENSITIVE, &gdk_color); 248 aColor = GDK_RGBA_TO_NS_RGBA(gdk_color); 249 break;
Attached patch patch (deleted) — Splinter Review
Pick up menu label widget to fetch inactive (gray) color.
Attachment #8612825 - Flags: review?(karlt)
Attachment #8612825 - Flags: review?(karlt) → review+
Assignee: nobody → stransky
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: