Closed
Bug 1169296
Opened 10 years ago
Closed 10 years ago
Intercepting top-level document loads is not working with JAR channels
Categories
(Core :: DOM: Service Workers, defect)
Core
DOM: Service Workers
Tracking
()
RESOLVED
FIXED
NGA S2 (12Jun)
| Tracking | Status | |
|---|---|---|
| firefox41 | --- | fixed |
People
(Reporter: ferjm, Assigned: ferjm)
References
Details
(Whiteboard: [s3])
Attachments
(2 files, 1 obsolete file)
|
(deleted),
patch
|
jdm
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
jdm
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Updated•10 years ago
|
|
||
Comment 1•10 years ago
|
||
Fernando you meant to block the sync meta or the sw meta?
Flags: needinfo?(ferjmoreno)
|
|
Assignee | |
Comment 2•10 years ago
|
||
Of course, yes. That's a good reflect of what I have in mind...
Flags: needinfo?(ferjmoreno)
|
|
Assignee | |
Comment 3•10 years ago
|
||
|
|
Assignee | |
Comment 4•10 years ago
|
||
Attachment #8612834 -
Flags: review?(josh)
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8612802 -
Flags: review?(josh)
|
||
Comment 5•10 years ago
|
||
It seems that this bug is necessary to make work app:// with SW, blocking for that case v2 meta. Please, change it if I am wrong. Thanks!
Blocks: ServiceWorkers-B2G
|
|
Assignee | |
Comment 6•10 years ago
|
||
|
||
Comment 7•10 years ago
|
||
Comment on attachment 8612802 [details] [diff] [review]
v1
Review of attachment 8612802 [details] [diff] [review]:
-----------------------------------------------------------------
::: modules/libjar/nsJARChannel.cpp
@@ +922,5 @@
> + // later if needed.
> + mOpened = true;
> +
> + if (mLoadGroup)
> + mLoadGroup->AddRequest(this, nullptr);
Let's split off the original code in ContinueAsyncOpen into a FinishAsyncOpen method and just call that here.
Attachment #8612802 -
Flags: review?(josh)
|
|
||
Updated•10 years ago
|
Attachment #8612834 -
Flags: review?(josh) → review+
|
||
Updated•10 years ago
|
Whiteboard: [s2] → [s3]
|
|
||
Updated•10 years ago
|
Target Milestone: --- → NGA S2 (12Jun)
|
|
Assignee | |
Comment 8•10 years ago
|
||
Attachment #8612802 -
Attachment is obsolete: true
Attachment #8614039 -
Flags: review?(josh)
|
|
||
Updated•10 years ago
|
Attachment #8614039 -
Flags: review?(josh) → review+
|
|
||
Updated•10 years ago
|
Status: NEW → ASSIGNED
|
||
Comment 10•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/54684722f9e8
https://hg.mozilla.org/mozilla-central/rev/c9a430de302f
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox41:
--- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•