Closed
Bug 1169370
Opened 9 years ago
Closed 9 years ago
Scrollbar slider occasionally disappears on GTK3
Categories
(Core :: Widget: Gtk, defect)
Core
Widget: Gtk
Tracking
()
RESOLVED
FIXED
mozilla41
Tracking | Status | |
---|---|---|
firefox41 | --- | fixed |
People
(Reporter: acomminos, Assigned: acomminos)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
jrmuizel
:
review+
|
Details | Diff | Splinter Review |
Occasionally, the page content's scrollbar slider will disappear on GTK 3.14 using Firefox built for GTK3. The most consistent way to reproduce this (even though it can't be reproduced 100% of the time) is to attempt to scroll a page while it loads. The slider reappears when hovering over where one would expect the scrollbar slider to be.
Assignee | ||
Comment 1•9 years ago
|
||
Strangely, if OMTC is disabled, scrollbar sliders are never visible.
Assignee | ||
Comment 2•9 years ago
|
||
The issue is caused by the fact that our tree cairo surface doesn't know that the underlying XLib surface has been modified on borrow when we draw widgets- it is believed to be clear. This patch marks it as dirty when the borrow ends, fixing the issue.
Attachment #8620443 -
Flags: review?(jmuizelaar)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → acomminos
Status: NEW → ASSIGNED
Comment 3•9 years ago
|
||
Comment on attachment 8620443 [details] [diff] [review] Mark tree Cairo surface dirty after borrow. Review of attachment 8620443 [details] [diff] [review]: ----------------------------------------------------------------- We should also call cairo_surface_flush() in init()
Attachment #8620443 -
Flags: review?(jmuizelaar) → review+
Assignee | ||
Comment 4•9 years ago
|
||
Flush the surface before the borrow begins, as per cairo docs.
Attachment #8620443 -
Attachment is obsolete: true
Attachment #8620482 -
Flags: review?(jmuizelaar)
Updated•9 years ago
|
Attachment #8620482 -
Flags: review?(jmuizelaar) → review+
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Comment 5•9 years ago
|
||
can we get a try run here, thanks!
Flags: needinfo?(acomminos)
Keywords: checkin-needed
Assignee | ||
Comment 6•9 years ago
|
||
GTK3 try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a2dbcc52b7d5
Flags: needinfo?(acomminos)
Assignee | ||
Comment 7•9 years ago
|
||
Changes in bug 1129873 caused GTK3 try bustage, updated try with fix: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5fb8ef159715
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Comment 8•9 years ago
|
||
(In reply to Andrew Comminos [:acomminos] from comment #7) > Changes in bug 1129873 caused GTK3 try bustage, updated try with fix: > > https://treeherder.mozilla.org/#/jobs?repo=try&revision=5fb8ef159715 this try run is full of failures like https://treeherder.mozilla.org/logviewer.html#?job_id=8451040&repo=try are those related to the patch ?
Flags: needinfo?(acomminos)
Keywords: checkin-needed
Assignee | ||
Comment 9•9 years ago
|
||
Unlikely; GTK3 builds currently aren't great on the test infrastructure (see https://treeherder.mozilla.org/#/jobs?repo=elm). Most of the failures are due to bug 1170342.
Flags: needinfo?(acomminos)
Keywords: checkin-needed
Comment 10•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/54386de97c76
Keywords: checkin-needed
Comment 11•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/54386de97c76
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox41:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in
before you can comment on or make changes to this bug.
Description
•