Closed
Bug 1169554
Opened 9 years ago
Closed 9 years ago
Do not try to reconnect on shutdown
Categories
(Core :: Networking, defect)
Core
Networking
Tracking
()
RESOLVED
FIXED
mozilla41
People
(Reporter: dragana, Assigned: dragana)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
mayhemer
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Since bug 1152041 we do not try to reconnect if we are offline. This can influence localhost connections so change it to !IsShutdown
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → dd.mozilla
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•9 years ago
|
||
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8612762 -
Flags: review?(honzab.moz)
|
|
Assignee | |
Comment 2•9 years ago
|
||
|
||
Updated•9 years ago
|
Attachment #8612762 -
Flags: review?(honzab.moz) → review+
|
|
Assignee | |
Updated•9 years ago
|
Keywords: checkin-needed
Keywords: checkin-needed
|
||
Comment 4•9 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox41:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
|
|
Assignee | |
Comment 5•9 years ago
|
||
Comment on attachment 8612762 [details] [diff] [review]
bug_1169554_v1.patch
Approval Request Comment
[Feature/regressing bug #]: Makes bug 1152041 more restrictive
[User impact if declined]:
[Describe test coverage new/current, TreeHerder]: Already in Nightly for some weeks
[Risks and why]: no risk
[String/UUID change made/needed]: none
Attachment #8612762 -
Flags: approval-mozilla-aurora?
|
||
Updated•9 years ago
|
status-firefox40:
--- → affected
|
|
||
Comment 6•9 years ago
|
||
Comment on attachment 8612762 [details] [diff] [review]
bug_1169554_v1.patch
Taking it to improve the stability.
But I do not agree with the risk evaluation, every change has risk.
Attachment #8612762 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
|
|
||
Comment 7•9 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•