Closed Bug 1169554 Opened 10 years ago Closed 9 years ago

Do not try to reconnect on shutdown

Categories

(Core :: Networking, defect)

Product:
Core
Component:
Networking
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla41
Tracking Flags:
Tracking Status
firefox40 --- fixed
firefox41 --- fixed

People

(Reporter: dragana, Assigned: dragana)

References

Details

Attachments

(1 file)

bug_1169554_v1.patch
(deleted), patch
mayhemer
: review+
Sylvestre
: approval-mozilla-aurora+
Details | Diff | Splinter Review
Since bug 1152041 we do not try to reconnect if we are offline. This can influence localhost connections so change it to !IsShutdown
Assignee: nobody → dd.mozilla
Status: NEW → ASSIGNED
Attached patch bug_1169554_v1.patch (deleted) — — Splinter Review
Attachment #8612762 - Flags: review?(honzab.moz)
Attachment #8612762 - Flags: review?(honzab.moz) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/b95c3dd6b73e
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox41: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Blocks: 1152041
Comment on attachment 8612762 [details] [diff] [review] bug_1169554_v1.patch Approval Request Comment [Feature/regressing bug #]: Makes bug 1152041 more restrictive [User impact if declined]: [Describe test coverage new/current, TreeHerder]: Already in Nightly for some weeks [Risks and why]: no risk [String/UUID change made/needed]: none
Attachment #8612762 - Flags: approval-mozilla-aurora?
Comment on attachment 8612762 [details] [diff] [review] bug_1169554_v1.patch Taking it to improve the stability. But I do not agree with the risk evaluation, every change has risk.
Attachment #8612762 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: