Closed
Bug 1169683
Opened 9 years ago
Closed 9 years ago
The chromeUI icon in the identity-popup is blurry on Windows HiDPI
Categories
(Firefox :: Theme, defect)
Firefox
Theme
Tracking
()
People
(Reporter: jaws, Assigned: jaws)
References
Details
Attachments
(2 files, 1 obsolete file)
(deleted),
patch
|
Gijs
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
lmandel
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
No description provided.
Flags: qe-verify-
Flags: firefox-backlog+
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8612957 -
Flags: review?(gijskruitbosch+bugs)
Assignee | ||
Comment 2•9 years ago
|
||
Comment on attachment 8612957 [details] [diff] [review]
Patch
Review of attachment 8612957 [details] [diff] [review]:
-----------------------------------------------------------------
::: browser/themes/shared/identity-block.inc.css
@@ +161,5 @@
> }
> +
> + #identity-popup.chromeUI > #identity-popup-container > #identity-popup-icon {
> + list-style-image: url("chrome://branding/content/icon128.png");
> + -moz-image-region: rect(0, 128px, 128px, 0);
NB: the -moz-image-region is needed in the shared file for the chromeUI because we don't have HiDPI icons for identity.png on Linux and Windows. It's also defined in the OSX file for #identity-popup-icon but I don't want to move that generic rule here since we are missing the identity@2x.png image and it will cause the 1x graphic to look worse in the interim.
Updated•9 years ago
|
Attachment #8612957 -
Flags: review?(gijskruitbosch+bugs) → review+
Comment hidden (typo) |
Comment hidden (typo) |
Updated•9 years ago
|
Attachment #8612984 -
Attachment is obsolete: true
Attachment #8612984 -
Flags: review?(ehsan)
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Keywords: checkin-needed
Comment 6•9 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
Assignee | ||
Comment 7•9 years ago
|
||
Approval Request Comment
[Feature/regressing bug #]: Windows 10 HiDPI
[User impact if declined]: HiDPI icons on Windows are blurry
[Describe test coverage new/current, TreeHerder]: on mozilla-central for much of 41-nightly
[Risks and why]: none expected
[String/UUID change made/needed]: none
https://hg.mozilla.org/try/pushloghtml?changeset=71084a9edf1e
Attachment #8627207 -
Flags: approval-mozilla-beta?
Updated•9 years ago
|
status-firefox40:
--- → affected
Comment 8•9 years ago
|
||
Comment on attachment 8627207 [details] [diff] [review]
Patch for 40
Visual fix in support of Windows 10. On m-c for more than a month. Beta+
Attachment #8627207 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 9•9 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•