Closed
Bug 1169718
Opened 9 years ago
Closed 9 years ago
[CL] Margin on right of "Open" buttons
Categories
(Firefox OS Graveyard :: Gaia::Customizer, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: drs, Assigned: pdahiya)
References
Details
(Whiteboard: [spark])
Attachments
(1 file)
There's a small margin to the right of the "Open" buttons. We should remove it and make the buttons flush with the right edge of the container list.
|
Reporter | |
Comment 1•9 years ago
|
||
Punam, can you take this?
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → pdahiya
Flags: needinfo?(pdahiya)
|
|
Assignee | |
Comment 2•9 years ago
|
||
Assigning myself to work on this.
|
|
Assignee | |
Comment 3•9 years ago
|
||
Hi Doug
Attaching PR that fixes margin on right of open buttons. Please review. Thanks!
Attachment #8613148 -
Flags: review?(drs)
|
|
Reporter | |
Comment 4•9 years ago
|
||
Comment on attachment 8613148 [details]
PR with fix of bug 1169718
I don't know this app very well. Justin, could you review this instead?
Attachment #8613148 -
Flags: review?(drs) → review?(jdarcangelo)
|
||
Comment 5•9 years ago
|
||
Comment on attachment 8613148 [details]
PR with fix of bug 1169718
LGTM
Attachment #8613148 -
Flags: review?(jdarcangelo) → review+
|
|
Assignee | |
Comment 6•9 years ago
|
||
Thanks Justin! Patch landed on master
https://github.com/fxos/customizer-launcher/commit/59f1f9f91b0c8dbc105468015e025c4537df8d2f
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•