Closed
Bug 1169850
Opened 9 years ago
Closed 9 years ago
PNK_EXPORT_FROM is not handled in BytecodeEmitter::emitTree.
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla41
Tracking | Status | |
---|---|---|
firefox41 | --- | fixed |
People
(Reporter: arai, Assigned: arai)
References
Details
Attachments
(1 file)
(deleted),
patch
|
shu
:
review+
|
Details | Diff | Splinter Review |
https://dxr.mozilla.org/mozilla-central/source/js/src/frontend/BytecodeEmitter.cpp?from=BytecodeEmitter.cpp&case=true#7506 > case PNK_IMPORT: > case PNK_EXPORT: > case PNK_EXPORT_FROM: > // TODO: Implement emitter support for modules > reportError(nullptr, JSMSG_MODULES_NOT_IMPLEMENTED); > return false; PNK_EXPORT_DEFAULT should be there.
Assignee | ||
Comment 1•9 years ago
|
||
Try is running: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d8475878269b
Assignee: nobody → arai.unmht
Assignee | ||
Comment 2•9 years ago
|
||
Added PNK_EXPORT_DEFAULT case, and a test just like bug1105608.js, which was for PNK_EXPORT_FROM.
Attachment #8613183 -
Flags: review?(shu)
Updated•9 years ago
|
Attachment #8613183 -
Flags: review?(shu) → review+
Comment 4•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/2925bc1c2a44
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in
before you can comment on or make changes to this bug.
Description
•