Closed
Bug 1170089
Opened 10 years ago
Closed 10 years ago
[Settings] Refactor simcard_fdn.js
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: eragonj, Assigned: eragonj)
References
Details
Attachments
(1 file)
Refactor simcard_fdn.js with AMD style and add unit tests for it.
|
||
Comment 1•10 years ago
|
||
|
Assignee | |
Comment 2•10 years ago
|
||
Comment on attachment 8613409 [details]
[gaia] EragonJ:bug-1170089 > mozilla-b2g:master
Arthur, can you help me check this patch ? Thanks !!
Attachment #8613409 -
Flags: review?(arthur.chen)
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8613409 [details]
[gaia] EragonJ:bug-1170089 > mozilla-b2g:master
Awesome! r=me with the nit, thanks!
Attachment #8613409 -
Flags: review?(arthur.chen) → review+
|
|
Assignee | |
Comment 5•10 years ago
|
||
Okay, it seems autolander is down, let me try to land this by myself.
Keywords: checkin-needed
|
|
Assignee | |
Comment 6•10 years ago
|
||
Thanks Arthur, this patch was merged into Gaia/master : https://github.com/mozilla-b2g/gaia/commit/ae4ef3f63b921fa46c20d9d4feb271713fb014ba
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•