Since May 30th we are seeing constant failures of the following Firefox UI Test: Traceback (most recent call last): File "/home/henrik/.virtualenvs/fxtests/local/lib/python2.7/site-packages/marionette_client-0.12-py2.7.egg/marionette/marionette_test.py", line 296, in run testMethod() File "/mozilla/code/firefox-ui-tests/firefox_ui_harness/decorators.py", line 23, in wrapper return target(self, *args, **kwargs) File "/mozilla/code/firefox-ui-tests/firefox_ui_tests/functional/locationbar/test_suggest_bookmarks.py", line 89, in test_star_in_autocomplete 'The auto-complete result is a bookmark') AssertionError: The auto-complete result is a bookmark Maybe we no longer show auto-complete items as bookmarks? Or classes have been changed. I will have a look at this in the next couple of hours. Maybe Marco has an idea meanwhile what could have caused it.

Changelog between those two builds from May 29th and 30th: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=f986e55c4e0b&tochange=45a4d6336c73 Probably that's the unified auto-complete as enabled via bug 1168811?

Turning off unified-autocomplete definitely fixes the problem for us. For now marking it as regression of bug 1168811.

The type attribute of the auto-complete entry only contains 'action searchengine' but no bookmark anymore. Marco, is this really expected?

Ah, so the search entry gets injected now as the first item in the auto-complete results list. That's why we have to check the second entry. Maybe it would be better to skip all search entries and check for the first real auto-complete. That would work with both unified-autocomplete turned on and off.

I went the easy way this time and simply hard-coded the changes. If it turns out that we have to disable unified auto-complete, I will get a more secure fix in place. For now that should be enough. If Travis is happy I will get it landed immediately so we will have hopefully green tests again.

https://github.com/mozilla/firefox-ui-tests/commit/25685f5b5732578cd631dbdc29250812293bc2a7 (master) I will re-open the bug if a more details fix will be necessary here.