Closed Bug 1170263 Opened 9 years ago Closed 9 years ago

Enabling resetting prefs and settings after non-root factory reset.

Categories

(Firefox OS Graveyard :: Gaia, defect, P1)

All
Gonk (Firefox OS)
defect

Tracking

(firefox41 fixed)

RESOLVED FIXED
2.2 S14 (12june)
Tracking Status
firefox41 --- fixed

People

(Reporter: yzen, Assigned: yzen)

References

Details

(Whiteboard: [spark])

Attachments

(1 file, 1 obsolete file)

In order for us to be able to switch between normal and unrestricted devtools in Gaia, we need to be able to reset appropriate settings and prefs.
Attached patch 1170263 patch v1 (obsolete) (deleted) — Splinter Review
Attachment #8613656 - Flags: review?(fabrice)
Comment on attachment 8613656 [details] [diff] [review]
1170263 patch v1

Review of attachment 8613656 [details] [diff] [review]:
-----------------------------------------------------------------

::: b2g/components/ProcessGlobal.js
@@ +69,5 @@
> +  // TODO: Remove once bug 1125916 is fixed.
> +  Services.prefs.setBoolPref("network.disable.ipc.security", unrestricted);
> +  Services.prefs.setBoolPref("dom.webcomponents.enabled", unrestricted);
> +  settings.createLock().set("developer.menu.enabled", unrestricted, null);
> +  settings.createLock().set("devtools.unrestricted", unrestricted, null);

Please use a single lock for this.
Attached patch 1170263 patch v2 (deleted) — Splinter Review
(In reply to Gregor Wagner [:gwagner] from comment #2)
> Comment on attachment 8613656 [details] [diff] [review]
> 1170263 patch v1
> 
> Review of attachment 8613656 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: b2g/components/ProcessGlobal.js
> @@ +69,5 @@
> > +  // TODO: Remove once bug 1125916 is fixed.
> > +  Services.prefs.setBoolPref("network.disable.ipc.security", unrestricted);
> > +  Services.prefs.setBoolPref("dom.webcomponents.enabled", unrestricted);
> > +  settings.createLock().set("developer.menu.enabled", unrestricted, null);
> > +  settings.createLock().set("devtools.unrestricted", unrestricted, null);
> 
> Please use a single lock for this.

Done
Attachment #8613656 - Attachment is obsolete: true
Attachment #8613656 - Flags: review?(fabrice)
Attachment #8613678 - Flags: review?(fabrice)
Attachment #8613678 - Flags: review?(fabrice) → review+
https://hg.mozilla.org/mozilla-central/rev/5befdd2d1ab2
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S14 (12june)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: