Closed
Bug 11709
Opened 25 years ago
Closed 13 years ago
Pref "browser.screen_resolution" is ignored -- ordering problem on startup
Categories
(Core Graveyard :: GFX, defect, P4)
Core Graveyard
GFX
Tracking
(Not tracked)
RESOLVED
WONTFIX
Future
People
(Reporter: sfraser_bugs, Unassigned)
References
Details
The user preference "browser.screen_resolution" is ignored, because it is read
before the user's prefs file has been read in.
"browser.screen_resolution" is read in nsDeviceContextMac.cpp, which is called
for the first window that is created. That is the hidden window, which gets
created when the nsAppShellService is initialized. However, this all happens
before ReadUserPrefs() is called, because we have to initialize the
nsAppShellService() to be able to do profile stuff.
So there's an ordering problem here on startup that needs fixing.
I have no idea who should get this bug, or what the correct fix is. So I'm giving
it to danm. Perhaps the hidden window should be created later?
The correct fix is to register a listener on the pref and when it changes,
update your variable. Minor details would be forcing all the window to redraw to
reflect the change. It shouldn't just be a startup issue as we might want to
provide UI switch to allow the user to change during runtime. My 2.5 cents.
Comment 2•25 years ago
|
||
David's comment is right on. That is the standard for using prefs - grab it
each time it's used or register a callback and update your cached value when it
changes.
Comment 3•25 years ago
|
||
mass-moving most m11 bugs to m12
Comment 4•25 years ago
|
||
Mass-moving non-PDT+ bugs to M13
preferences plumbing, then. gramps sez mcafee will find a caring home for this one.
Updated•25 years ago
|
Target Milestone: M13
Comment 6•25 years ago
|
||
sounds easy, m13.
Updated•25 years ago
|
QA Contact: don → sairuh
Comment 7•25 years ago
|
||
spam: added self to cc list as this might affect my realm.
Updated•25 years ago
|
Target Milestone: M16 → M18
Comment 11•24 years ago
|
||
nav triage team:
We would like to get this fixed, but lower priority. Nsbeta1, p4, reassign to
pchen
Updated•24 years ago
|
Target Milestone: --- → mozilla1.0
Updated•24 years ago
|
Comment 12•24 years ago
|
||
nav triage: not a nsCatFood issue for common usage. Moving to Future. if you
want to renominate this bug for catFood, please explain the user impact clearly
and the frequency, severity and percentage of users it would impact.
Keywords: nsCatFood → nsCatFood-
Target Milestone: mozilla1.0 → Future
Comment 15•23 years ago
|
||
Shouldn't this be a per-machine pref rather than a per-user pref? (and even
further, a per-X-server pref, on Linux?)
I don't see why two users would have two different resolutions on the same
computer... That seems contradictory to me.
Comment 16•23 years ago
|
||
-> default assignee
Assignee: pchen → trudelle
Target Milestone: Future → ---
Comment 18•23 years ago
|
||
not an XPApps bug
Assignee: ben → attinasi
Component: XP Apps → Layout
QA Contact: sairuh → petersen
Comment 19•23 years ago
|
||
Reassigning to Don
Assignee: attinasi → dcone
Target Milestone: --- → Future
Comment 20•22 years ago
|
||
> I don't see why two users would have two different resolutions
"startx" with different arguments, leading to different X resolutions.
That said, I assume this is still an issue. Is some mac person willing to own this?
Reporter | ||
Updated•20 years ago
|
Assignee: sfraser_bugs → general
QA Contact: chrispetersen → ian
Updated•16 years ago
|
Assignee: general → nobody
QA Contact: ian → general
Assignee | ||
Updated•16 years ago
|
Product: Core → Core Graveyard
Comment 22•13 years ago
|
||
I'm closing this as WONTFIX (really as MOOT) because the string "screen_resolution" is no longer anywhere to be found in the source tree (except one e4x test case that is just using a prefs dump as a big XML file). If there is still a problem with screen resolution adjustment however that's done now, please file a new bug.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → WONTFIX
Comment 23•13 years ago
|
||
the pref was renamed to layout.css.dpi
Comment 24•13 years ago
|
||
Ah. Do you disagree with closing the bug?
Comment 25•13 years ago
|
||
no, because the code to read the pref was entirely rewritten and I believe it works now
You need to log in
before you can comment on or make changes to this bug.
Description
•