I have a problem where a toolbarbutton with type="panel" isn't allowed to include a badge. This patch seems to fix the problem.

Comment on attachment 8614931 [details] [diff] [review] patch Review of attachment 8614931 [details] [diff] [review]: ----------------------------------------------------------------- Neil, does this look right to you? I kind of wish we could do this without yet another binding. Bill, is there some reason you didn't keep the hbox/vbox structure inside the toolbarbutton[type="menu"]'s structure? Also, have you tested what this looks like in practice, ie if the styling all works out?

Comment on attachment 8614931 [details] [diff] [review] patch Seems reasonable to me, but I'd add support for [type="menu"] too for consistency, unless there's a particular reason not to.

(In reply to Gijs Kruitbosch from comment #1) > Neil, does this look right to you? I kind of wish we could do this without > yet another binding. I guess the way to go there would be to wrap the <img> in a box in the base binding, then when you want a badge, add a binding to the wrapper box that provides the badge.