Closed
Bug 1171230
Opened 10 years ago
Closed 10 years ago
Include parent window ID in nsIWebProgress
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
INVALID
Tracking | Status | |
---|---|---|
firefox41 | --- | affected |
People
(Reporter: billm, Assigned: billm)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
(deleted),
patch
|
smaug
:
review-
|
Details | Diff | Splinter Review |
(deleted),
patch
|
Details | Diff | Splinter Review |
This is a useful feature to have, particularly for e10s. It's needed so we can implement the semantics of Chrome's webNavigation API for extensions.
Assignee | ||
Comment 1•10 years ago
|
||
These are the platform changes.
Attachment #8614943 -
Flags: review?(bugs)
Assignee | ||
Comment 2•10 years ago
|
||
Here's the toolkit patch.
Attachment #8614944 -
Flags: review?(felipc)
Comment 3•10 years ago
|
||
I don't quite understand the need of this.
Comment 4•10 years ago
|
||
And what should parentWindowID be in case window->GetParent() returns the window itself?
Comment 5•10 years ago
|
||
Comment on attachment 8614943 [details] [diff] [review]
patch
I have the gut feeling this isn't quite what you mean, especially since
DOMWindowID can be the same as parentWindowID. that is an odd API.
(I know, DOM is odd since window.parent can be the window itself).
So, at least change the name of the property
'parentOrSelfWindowID' and then document what the ID actually is.
Attachment #8614943 -
Flags: review?(bugs) → review-
Assignee | ||
Updated•10 years ago
|
Attachment #8614944 -
Flags: review?(felipc)
Assignee | ||
Comment 6•10 years ago
|
||
Thinking about this more, I guess I don't really need this. I wanted it since the window ID isn't available in the parent process. However, since writing this patch, I rewrote the code that was depending on it to run in a frame script. So it's not necessary.
Assignee | ||
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → INVALID
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•