Open Bug 1171316 Opened 9 years ago Updated 2 years ago

View source in tab's go to line fails if accesskey blocked

Categories

(Toolkit :: View Source, defect)

defect

Tracking

()

People

(Reporter: bzbarsky, Unassigned)

References

Details

[Tracking Requested - why for this release]: Serious view-source usability regression A normal view-source window has an option for going to a particular line in a file. view-source in a tab doesn't have that. Maybe this is something Paul thought was unimportant in bug 1067325 comment 1? I use this all the time....
Go to line is also in the context menu, and you can press Ctrl-Option-L / Alt-Shift-L to trigger it, depending on OS. Does this work for you?
Flags: needinfo?(bzbarsky)
> and you can press Ctrl-Option-L / Alt-Shift-L to trigger it Ctrl-Option-L doesn't seem to trigger it on Mac for me. Neither does Alt-Shift-L, of course. Either way, it's too bad we had to change the shortcut, given muscle memory. :(
Flags: needinfo?(bzbarsky)
Hmm, Ctrl-Opt-L appears to work on Mac for me. The key binding was added later in bug 1168081, after the original view source tab work. It landed in m-c at 2015-05-29 15:59:34 CDT, is your build new enough? There is still a known issue if the view source was restored by session restore (after restarting Firefox), so currently it will only work for a view source tab opened in the current session. Any luck given this extra info?
Flags: needinfo?(bzbarsky)
> is your build new enough? I'm on a 2015-06-03 nightly. I did just check that it works in a vanilla profile in this build. It does not work in my normal profile. So I did some bisecting on my prefs.js and it looks like this accessibility preference causes this keybinding to not work: user_pref("accessibility.accesskeycausesactivation", false);
Flags: needinfo?(bzbarsky) → needinfo?(jryans)
(In reply to Not doing reviews right now from comment #4) > > is your build new enough? > > I'm on a 2015-06-03 nightly. I did just check that it works in a vanilla > profile in this build. It does not work in my normal profile. > > So I did some bisecting on my prefs.js and it looks like this accessibility > preference causes this keybinding to not work: > > user_pref("accessibility.accesskeycausesactivation", false); Ah, thanks! That setup does block the shortcut here too. We could change to trapping a regular key event, instead of the accesskey. Not sure how many others will encounter this, or even realize there's a shortcut bound at all...
Blocks: 1168081
No longer blocks: 1067325
Flags: needinfo?(jryans)
Summary: View source in tab doesn't have a way to go to line like normal view source does → View source in tab's go to line fails if accesskey blocked
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.