> JavaScript warning: file:///builds/slave/test/build/tests/jsreftest/tests/js1_8/extensions/regress-476427.js, line 1: JavaScript 1.6's for-each-in loops are deprecated; consider using ES6 for-of instead It looks like we can just update the use of "for each" [1]. [1] https://hg.mozilla.org/mozilla-central/annotate/98820360ab66/js/src/tests/js1_8/extensions/regress-476427.js#l34

Gary, can you propose a fix for this? Would switching to "for y of this" suffice to maintain what we're testing here?

Doesn't look like it. for-each iterates over the *values* of properties on the provided value (coerced to an object if necessary, as I recall). for-of invokes the ES6 iterator protocol, which requires opt-in from the object in question. In the standard library only arrays really opted into that, as I recall. Given the problem was only fixed happenstantially by some other bug, we have no idea what this test was *actually* trying to test, so I'd say do the Minimum Viable Thing That Looks Vaguely Similar. Perhaps this fits, here: foo("for (yyy in this) y = this[yyy];");

url: https://hg.mozilla.org/integration/mozilla-inbound/rev/085f96014278d0cbef9e3a372146cc3ed406224e changeset: 085f96014278d0cbef9e3a372146cc3ed406224e user: Eric Rahm <erahm@mozilla.com> date: Wed Jul 15 20:28:07 2015 -0700 description: Bug 1171586 - Remove for-each-in from regress-476427.js. r=waldo

Backed out for various SM permafails. https://treeherder.mozilla.org/logviewer.html#?job_id=11756586&repo=mozilla-inbound https://hg.mozilla.org/integration/mozilla-inbound/rev/e123787104f7

This is probably more appropriate for someone working on the JS engine.

I don't think there is much value in fixing 10 year old fuzz bugs, when at the time of check-in the fix wasn't even in that bug.

Comment on attachment 8778830 [details] [diff] [review] Remove test with for-each in Review of attachment 8778830 [details] [diff] [review]: ----------------------------------------------------------------- I agree. the target of this testcase doesn't exist anymore.

Pushed by evilpies@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/59d426e1165a Remove regress-476427.js test. r=arai