Joel Maher ( :jmaher ) (UTC -8) Reporter
	Description • 9 years ago

Talos has detected a Firefox performance regression from your commit a3a13b2f6d14 in bug 1163231.  We need you to address this regression.

This is a list of all known regressions and improvements related to your bug:
http://alertmanager.allizom.org:8080/alerts.html?rev=a3a13b2f6d14&showAll=1

On the page above you can see Talos alert for each affected platform as well as a link to a graph showing the history of scores for this test. There is also a link to a treeherder page showing the Talos jobs in a pushlog format.

To learn more about the regressing test, please see: https://wiki.mozilla.org/Buildbot/Talos/Tests#tresize

Reproducing and debugging the regression:
If you would like to re-run this Talos test on a potential fix, use try with the following syntax:
try: -b o -p win32 -u none -t chromez  # add "mozharness: --spsProfile" to generate profile data

To run the test locally and do a more in-depth investigation, first set up a local Talos environment:
https://wiki.mozilla.org/Buildbot/Talos/Running#Running_locally_-_Source_Code

Then run the following command from the directory where you set up Talos:
talos --develop -e <path>/firefox -a tresize

Making a decision:
As the patch author we need your feedback to help us handle this regression.
*** Please let us know your plans by Monday, or the offending patch will be backed out! ***

Our wiki page oulines the common responses and expectations:
https://wiki.mozilla.org/Buildbot/Talos/RegressionBugsHandling

	Joel Maher ( :jmaher ) (UTC -8) Reporter
	Comment 1 • 9 years ago

:adw, I know we have a hit with pocket in general- it seems that this is the test that we keep running into.  :jaws had done a lot of work in the past to optimize pocket integration- this tresize wasn't on the original list.  Please comment on your ideal path forward here.

	Drew Willcoxon :adw
	Comment 2 • 9 years ago

It's probably due to the Pocket button causing the toolbar to overflow on Developer Edition where there was no overflow before: the overflowed toolbar is "heavier" than the non-overflowed toolbar, and the test sizes the window such that it's exercising the overflowed toolbar.  If that's the case I don't think this is a meaningful regression except that it points out that resizing the window while the toolbar is overflowed is slower than while it's not overflowed, which isn't this patch's fault.

	Joel Maher ( :jmaher ) (UTC -8) Reporter
	Comment 3 • 9 years ago

agree- if that is the case, then this is not specific to pocket.  Given the nature of the previous regressions, etc. your theory sounds plausible.