Closed
Bug 1172182
Opened 9 years ago
Closed 9 years ago
Make a devtools/memory module
Categories
(DevTools :: Performance Tools (Profiler/Timeline), defect)
Tracking
(firefox41 fixed)
RESOLVED
FIXED
Firefox 41
Tracking | Status | |
---|---|---|
firefox41 | --- | fixed |
People
(Reporter: jsantell, Assigned: jsantell)
References
Details
Attachments
(1 file)
(deleted),
patch
|
vporof
:
review+
|
Details | Diff | Splinter Review |
Pull out the memory logic from the memory actor, so it can be consumed by other actors that do not want to expose the actual actor itself.
This is mostly done for the memory actor (actors/utils/memory-bridge.js) but should be more consistent with the other performance actors being pulled out as well.
Assignee | ||
Comment 1•9 years ago
|
||
Updated•9 years ago
|
Attachment #8617668 -
Flags: review?(vporof) → review+
Assignee | ||
Comment 2•9 years ago
|
||
Whiteboard: [fixed-in-fx-team]
Comment 4•9 years ago
|
||
Comment on attachment 8617668 [details] [diff] [review]
1172182-memoryactor.patch
Review of attachment 8617668 [details] [diff] [review]:
-----------------------------------------------------------------
::: toolkit/devtools/server/actors/memory.js
@@ +28,5 @@
> * An actor that returns memory usage data for its parent actor's window.
> * A tab-scoped instance of this actor will measure the memory footprint of its
> * parent tab. A global-scoped instance however, will measure the memory
> * footprint of the chrome window referenced by the root actor.
> + *
Nit: pls land a follow up for this trailing whitespace.
https://hg.mozilla.org/mozilla-central/rev/7bc47a30831f
https://hg.mozilla.org/mozilla-central/rev/ea7e872d6e4c
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 41
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•