Closed
Bug 1172446
Opened 9 years ago
Closed 9 years ago
Rename Tagged to Sanitizer
Categories
(Firefox OS Graveyard :: Gaia::Shared, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.2 S14 (12june)
People
(Reporter: freddy, Assigned: kgrandon)
Details
(Whiteboard: [systemsfe])
Attachments
(2 files)
Rename the file from tagged.js to sanitizer.js.
Rename the exposed object from Tagged to Sanitizer
and modify all files currently using it.
Assignee | ||
Comment 1•9 years ago
|
||
I don't mind taking this, thanks for filing.
Assignee: nobody → kgrandon
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•9 years ago
|
||
Assignee | ||
Comment 3•9 years ago
|
||
Assignee | ||
Updated•9 years ago
|
Attachment #8617079 -
Attachment description: Pull Request - Rename Tagged to Sanitizer → [Gaia] Pull Request - Rename Tagged to Sanitizer
Assignee | ||
Comment 4•9 years ago
|
||
Comment on attachment 8617079 [details]
[Gaia] Pull Request - Rename Tagged to Sanitizer
Freddy - Any chance you would mind helping me give this rename a review?
Attachment #8617079 -
Flags: review?(fbraun)
Assignee | ||
Comment 5•9 years ago
|
||
Comment on attachment 8617084 [details]
[Plugin] Pull Request - Rename Tagged to Sanitizer
Freddy - would you mind helping me land this eslint plugin update? I guess we should also bump the npm version?
Attachment #8617084 -
Flags: review?(fbraun)
Reporter | ||
Comment 6•9 years ago
|
||
Comment on attachment 8617084 [details]
[Plugin] Pull Request - Rename Tagged to Sanitizer
Merged!
I will create a new version of the plugin and publish to npm this morning.
Attachment #8617084 -
Flags: review?(fbraun) → review+
Reporter | ||
Comment 7•9 years ago
|
||
Comment on attachment 8617079 [details]
[Gaia] Pull Request - Rename Tagged to Sanitizer
Thanks for taking this! Looks really good, but be reminded, that I can't give landing approval for modules I'm no peer of. :-)
Attachment #8617079 -
Flags: review?(fbraun) → feedback+
Reporter | ||
Comment 8•9 years ago
|
||
(In reply to Frederik Braun [:freddyb] from comment #6)
> I will create a new version of the plugin and publish to npm this morning.
Published as 0.1.5.
https://www.npmjs.com/package/eslint-plugin-no-unsafe-innerhtml
Assignee | ||
Comment 9•9 years ago
|
||
Comment on attachment 8617079 [details]
[Gaia] Pull Request - Rename Tagged to Sanitizer
Great, thanks for taking a look! Since this is in shared/, is only a rename, and the try run is green, going to go with r=me.
Attachment #8617079 -
Flags: review+
Assignee | ||
Comment 10•9 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Updated•9 years ago
|
Whiteboard: [systemsfe]
Target Milestone: --- → 2.2 S14 (12june)
You need to log in
before you can comment on or make changes to this bug.
Description
•