Ryan VanderMeulen [:RyanVM] Reporter
	Description • 9 years ago

https://treeherder.mozilla.org/logviewer.html#?job_id=8237234&repo=try

21:46:43 WARNING - TEST-UNEXPECTED-FAIL | tests/jit-test/jit-test/tests/basic/syntax-error-illegal-character.js | /builds/slave/test/build/tests/jit-test/jit-test/tests/basic/syntax-error-illegal-character.js:11:4 Error: Assertion failed: got "class is a reserved identifier", expected "illegal character": export class @ (code 3, args "")

	Ryan VanderMeulen [:RyanVM] Reporter
	Comment 1 • 9 years ago

TEST-UNEXPECTED-FAIL | js/src/jit-test/tests/modules/export-declaration.js | /builds/slave/try_lx-d_sm-arm-sim-0000000000/src/js/src/jit-test/tests/modules/export-declaration.js:214:0 SyntaxError: class is a reserved identifier (code 3, args "")

	Ryan VanderMeulen [:RyanVM] Reporter
	Comment 2 • 9 years ago

And jsreftest failures:

https://treeherder.mozilla.org/logviewer.html#?job_id=8237231&repo=try

REFTEST TEST-UNEXPECTED-FAIL | file:///builds/slave/test/build/tests/jsreftest/tests/jsreftest.html?test=ecma_6/Class/newTargetMethods.js | Unknown file:///builds/slave/test/build/tests/jsreftest/tests/ecma_6/Class/newTargetMethods.js:11: SyntaxError: class is a reserved identifier item 1
REFTEST TEST-UNEXPECTED-FAIL | file:///builds/slave/test/build/tests/jsreftest/tests/jsreftest.html?test=ecma_6/Class/superPropEvalInsideArrow.js | Unknown file:///builds/slave/test/build/tests/jsreftest/tests/ecma_6/Class/superPropEvalInsideArrow.js:1: SyntaxError: class is a reserved identifier item 1
REFTEST TEST-UNEXPECTED-FAIL | file:///builds/slave/test/build/tests/jsreftest/tests/jsreftest.html?test=ecma_6/Class/superPropHeavyweightArrow.js | Unknown file:///builds/slave/test/build/tests/jsreftest/tests/ecma_6/Class/superPropHeavyweightArrow.js:1: SyntaxError: class is a reserved identifier item 1

	Jon Coppeard (:jonco) (PTO until 14th September) Assignee
	Comment 3 • 9 years ago

Potential fix, waiting for try to reopen so I can test this.

	Jon Coppeard (:jonco) (PTO until 14th September) Assignee
	Comment 4 • 9 years ago

Comment on attachment 8617332 [details] [diff] [review]
bug1172641-syntax-test-aurora

This fixes the class-related failures on aurora.

	Shu-yu Guo [:shu]
	Comment 5 • 9 years ago

Comment on attachment 8617332 [details] [diff] [review]
bug1172641-syntax-test-aurora

Review of attachment 8617332 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for fix!

::: js/src/tests/ecma_6/Class/newTargetMethods.js
@@ +52,3 @@
>  
> +if (classesEnabled())
> +    eval(test);

Why'd you do it this way, to avoid moving code around? Just curious, no need to change what you did.

	Jon Coppeard (:jonco) (PTO until 14th September) Assignee
	Comment 6 • 9 years ago

(In reply to Shu-yu Guo [:shu] from comment #5)
> Why'd you do it this way, to avoid moving code around? 

I just copied what other class tests do to get around this problem.

	Pulsebot
	Comment 7 • 9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/bf800c62eeba

	Carsten Book [:Tomcat]
	Comment 8 • 9 years ago

sorry had to back this out in https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=4d38c2c86ba4 seems one of this changes caused a linux memory leak like :


https://treeherder.mozilla.org/logviewer.html#?job_id=10663696&repo=mozilla-inbound

	Pulsebot
	Comment 9 • 9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/4b5c070f23b3

	Carsten Book [:Tomcat]
	Comment 10 • 9 years ago

oh seems this one was innocent, so relanded as https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=4b5c070f23b3

	Pulsebot
	Comment 11 • 9 years ago

Backout:
https://hg.mozilla.org/integration/mozilla-inbound/rev/637b40497d85

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 12 • 9 years ago

https://hg.mozilla.org/mozilla-central/rev/4b5c070f23b3