Closed Bug 1172641 Opened 9 years ago Closed 9 years ago

syntax-error-illegal-character.js, export-declaration.js, and various jsreftests are going to permafail when Gecko 41 merges to Aurora

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla41
Tracking Flags:
Tracking Status
firefox41 --- verified

People

(Reporter: RyanVM, Assigned: jonco)

References

Details

Attachments

(1 file)

bug1172641-syntax-test-aurora
(deleted), patch
shu
: review+
Details | Diff | Splinter Review
https://treeherder.mozilla.org/logviewer.html#?job_id=8237234&repo=try 21:46:43 WARNING - TEST-UNEXPECTED-FAIL | tests/jit-test/jit-test/tests/basic/syntax-error-illegal-character.js | /builds/slave/test/build/tests/jit-test/jit-test/tests/basic/syntax-error-illegal-character.js:11:4 Error: Assertion failed: got "class is a reserved identifier", expected "illegal character": export class @ (code 3, args "")
Flags: needinfo?(jcoppeard)
TEST-UNEXPECTED-FAIL | js/src/jit-test/tests/modules/export-declaration.js | /builds/slave/try_lx-d_sm-arm-sim-0000000000/src/js/src/jit-test/tests/modules/export-declaration.js:214:0 SyntaxError: class is a reserved identifier (code 3, args "")
Summary: syntax-error-illegal-character.js is going to permafail when Gecko 41 merges to Aurora → syntax-error-illegal-character.js and export-declaration.js are going to permafail when Gecko 41 merges to Aurora
And jsreftest failures: https://treeherder.mozilla.org/logviewer.html#?job_id=8237231&repo=try REFTEST TEST-UNEXPECTED-FAIL | file:///builds/slave/test/build/tests/jsreftest/tests/jsreftest.html?test=ecma_6/Class/newTargetMethods.js | Unknown file:///builds/slave/test/build/tests/jsreftest/tests/ecma_6/Class/newTargetMethods.js:11: SyntaxError: class is a reserved identifier item 1 REFTEST TEST-UNEXPECTED-FAIL | file:///builds/slave/test/build/tests/jsreftest/tests/jsreftest.html?test=ecma_6/Class/superPropEvalInsideArrow.js | Unknown file:///builds/slave/test/build/tests/jsreftest/tests/ecma_6/Class/superPropEvalInsideArrow.js:1: SyntaxError: class is a reserved identifier item 1 REFTEST TEST-UNEXPECTED-FAIL | file:///builds/slave/test/build/tests/jsreftest/tests/jsreftest.html?test=ecma_6/Class/superPropHeavyweightArrow.js | Unknown file:///builds/slave/test/build/tests/jsreftest/tests/ecma_6/Class/superPropHeavyweightArrow.js:1: SyntaxError: class is a reserved identifier item 1
Summary: syntax-error-illegal-character.js and export-declaration.js are going to permafail when Gecko 41 merges to Aurora → syntax-error-illegal-character.js, export-declaration.js, and various jsreftests are going to permafail when Gecko 41 merges to Aurora
Assignee: nobody → jcoppeard
Flags: needinfo?(jcoppeard)
Attached patch bug1172641-syntax-test-aurora (deleted) — — Splinter Review
Potential fix, waiting for try to reopen so I can test this.
Comment on attachment 8617332 [details] [diff] [review] bug1172641-syntax-test-aurora This fixes the class-related failures on aurora.
Attachment #8617332 - Flags: review?(shu)
Comment on attachment 8617332 [details] [diff] [review] bug1172641-syntax-test-aurora Review of attachment 8617332 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for fix! ::: js/src/tests/ecma_6/Class/newTargetMethods.js @@ +52,3 @@ > > +if (classesEnabled()) > + eval(test); Why'd you do it this way, to avoid moving code around? Just curious, no need to change what you did.
Attachment #8617332 - Flags: review?(shu) → review+
(In reply to Shu-yu Guo [:shu] from comment #5) > Why'd you do it this way, to avoid moving code around? I just copied what other class tests do to get around this problem.
sorry had to back this out in https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=4d38c2c86ba4 seems one of this changes caused a linux memory leak like : https://treeherder.mozilla.org/logviewer.html#?job_id=10663696&repo=mozilla-inbound
Flags: needinfo?(jcoppeard)
oh seems this one was innocent, so relanded as https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=4b5c070f23b3
Flags: needinfo?(jcoppeard)
https://hg.mozilla.org/mozilla-central/rev/4b5c070f23b3
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox41: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Status: RESOLVED → VERIFIED
status-firefox41: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: