Closed
Bug 1172779
Opened 9 years ago
Closed 9 years ago
Customizer Launcher displays "Communications" instead of "Dialer" and "Contacts"
Categories
(Firefox OS Graveyard :: Gaia::Customizer, defect, P1)
Firefox OS Graveyard
Gaia::Customizer
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: drs, Assigned: pdahiya)
References
Details
(Keywords: dogfood, Whiteboard: [bzlite][spark])
Attachments
(1 file)
User-Agent: Mozilla/5.0 (Mobile; rv:41.0) Gecko/41.0 Firefox/41.0
We should just hard code the handling for these apps. It's not worth properly handling multiple entry points.
|
Reporter | |
Comment 1•9 years ago
|
||
Punam, can you take this?
Note that the Communications app is the only one that still uses "entry_points" in the manifest. That's why I suggested hardcoding in the Dialer and Contacts apps, rather than parsing the "entry_points".
Blocks: spark-customizer-launcher
Component: Gaia::Feedback → Gaia::Customizer
Flags: needinfo?(pdahiya)
Priority: -- → P1
Whiteboard: [bzlite] → [bzlite][spark]
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → pdahiya
Flags: needinfo?(pdahiya)
|
|
Assignee | |
Comment 2•9 years ago
|
||
Hi Justin
Attaching patch that shows Dialer and Contacts app in CL in place of Communications. Patch also addresses UI fix asked in https://bugzilla.mozilla.org/show_bug.cgi?id=1133943#c13 for CL.
Please review. Thanks!
Attachment #8621705 -
Flags: review?(jdarcangelo)
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8621705 [details]
PR with fix of Bug1172779
Left some comments in the PR and talked with Punam on IRC about making this a bit more dynamic and not keying off the `name`.
Attachment #8621705 -
Flags: review?(jdarcangelo) → review-
|
|
Assignee | |
Comment 4•9 years ago
|
||
Comment on attachment 8621705 [details]
PR with fix of Bug1172779
Hi Justin
Setting review flag on the patch updated with feedback. Please review. Thanks!
Attachment #8621705 -
Flags: review- → review?(jdarcangelo)
|
|
||
Comment 5•9 years ago
|
||
Comment on attachment 8621705 [details]
PR with fix of Bug1172779
Much better! I left one comment on the PR that points out a small change that might make this work for apps other than "communications" that use entry points (although, I'm not aware of any others ATM).
Attachment #8621705 -
Flags: review?(jdarcangelo) → review+
|
|
Assignee | |
Comment 6•9 years ago
|
||
(In reply to Justin D'Arcangelo [:justindarc] from comment #5)
> Comment on attachment 8621705 [details]
> PR with fix of Bug1172779
>
> Much better! I left one comment on the PR that points out a small change
> that might make this work for apps other than "communications" that use
> entry points (although, I'm not aware of any others ATM).
Updated patch in favor of removing hard coded communications mainfest url with app.manifest.entry_points to make it generic for parsing all apps with entry_points.
|
|
Assignee | |
Comment 7•9 years ago
|
||
Patch landed on master
https://github.com/fxos/customizer-launcher/commit/d798c2fd05cf883d69686b277b1c9c9a42a0261e
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•