Closed Bug 1173017 Opened 9 years ago Closed 9 years ago

Building deadlock detector with stacks enabled is broken

Categories

(Core :: XPCOM, defect)

defect
Not set
normal

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: erahm, Assigned: erahm)

References

Details

Attachments

(1 file)

It appears libxpcomrt does not include nsStackWalk.cpp which causes build failures when enabling stacks in deadlock detection.
Attachment #8617439 - Flags: review?(nfroyd)
Comment on attachment 8617439 [details] [diff] [review] Fix building deadlock detector with stacks enabled Review of attachment 8617439 [details] [diff] [review]: ----------------------------------------------------------------- I am a little tempted to say that nsStackWalk.cpp should only go in if DEBUG, but I think we can trust the compiler/linker to take care of the nsStackWalk.cpp code that we're not using. f? gcp on that, just to make sure...and do we have those libxpcomrt builds stood up on treeherder yet?
Attachment #8617439 - Flags: feedback?(gpascutto)
:glandium suggested that bug 1172216 will fix this, I tested the WIP patch and that seems to be the case.
Depends on: 1172216
Comment on attachment 8617439 [details] [diff] [review] Fix building deadlock detector with stacks enabled Lets wait until the blocking bug lands and see if that fixes things on all platforms.
Attachment #8617439 - Flags: review?(nfroyd)
Attachment #8617439 - Flags: feedback?(gpascutto)
libxpcomrt is dead, this is no longer an issue.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: