Closed Bug 1173520 Opened 9 years ago Closed 9 years ago

Implement support for failed test screenshots on GTK3

Categories

(Core :: Widget: Gtk, defect)

Product:
Core
Component:
Widget: Gtk
Platform:
Unspecified
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla41
Tracking Flags:
Tracking Status
firefox41 --- fixed

People

(Reporter: acomminos, Assigned: acomminos)

References

Details

Attachments

(2 files, 2 obsolete files)

Add support for test screenshots on GTK3.
(deleted), patch
karlt
: review+
Details | Diff | Splinter Review
Updated patch.
(deleted), patch
hub
: review+
Details | Diff | Splinter Review 
Currently, testing/tools/screenshot/gdk-screenshot.cpp is not implemented to take screenshots on GTK3.

It would be pretty nice to have screenshots of failed tests.
Summary: Implement support for screenshots on GTK3 → Implement support for failed test screenshots on GTK3

        Attachment #8620532 -
        Flags: review?(karlt)

        Attachment #8620532 -
        Flags: review?(karlt) → review+

    
  
Keywords: checkin-needed

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/63fd849c06a3
Status: ASSIGNED → RESOLVED
Closed: 9 years ago

          status-firefox41:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41

    
    

    
  
Unfortunately this doesn't build of Fedora 22.

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Proposed patch (obsolete) (deleted)
        — 
          — Splinter Review
      

    


  
Karl

Since you reviewed the first one. This is a bustage for me.

        Attachment #8621415 -
        Flags: review?(karlt)

    
    

    
  
Comment on attachment 8621415 [details] [diff] [review]
Proposed patch

>+#if (MOZ_WIDGET_GTK == 2)
>+      GDK_DISPLAY(),
>+#else
>+      GDK_DISPLAY_XDISPLAY(gdk_display_get_default()),
>+#endif

Thanks.  Please drop the (MOZ_WIDGET_GTK == 2) blocks as GDK_DISPLAY_XDISPLAY(gdk_display_get_default()) will work on GTK2 also.

        Attachment #8621415 -
        Flags: review?(karlt) → review+

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Updated patch (obsolete) (deleted)
        — 
          — Splinter Review
      

    


  
Carrying the r+

        Attachment #8621415 -
        Attachment is obsolete: true

        Attachment #8621424 -
        Flags: review+
Status: RESOLVED → REOPENED
Keywords: checkin-needed
Resolution: FIXED → ---

    
    

    
  
Please attach a patch that includes all proper commit information.
Flags: needinfo?(hub)
Keywords: checkin-needed

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Updated patch. (deleted)
        — 
          — Splinter Review
      

    


  
Was missing "User". Carrying the r+ forward.

        Attachment #8621424 -
        Attachment is obsolete: true
Flags: needinfo?(hub)

        Attachment #8621609 -
        Flags: review+
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: