Closed Bug 1173657 Opened 9 years ago Closed 9 years ago

MediaFormatReader should drain its decoder when encountering waiting for data error

Categories

(Core :: Audio/Video, defect)

Product:
Core
Component:
Audio/Video
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla42
Tracking Flags:
Tracking Status
firefox41 --- affected
firefox42 --- fixed

People

(Reporter: jya, Assigned: jya)

References

Details

Attachments

(1 file)

Drain decoder when discontinuity encountered.
(deleted), patch
cpearce
: review+
Details | Diff | Splinter Review
When the MediaFormatReader attempt to demux a frame, but the demuxer returns WAITING_FOR_DATA, it rejects the promise and enter wait mode (giving the MDSM a WaitingPromise). It should attempt to drain the decoder first prior to rejecting the promise as there may be queued decoded frames ready to be output by the decoder.
Blocking bug 1171379, as if we don't drain, the waiting event will be fired on a different time than what test_WaitingOnMissingData_mp4.html expects.
Blocks: 1171379
A discontinuity can be when waiting for data, decoding error or reaching end of stream.
Attachment #8632684 - Flags: review?(cpearce)
Attachment #8632684 - Flags: review?(cpearce) → review+
Assignee: nobody → jyavenard
https://hg.mozilla.org/mozilla-central/rev/80f9da7f0806
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox42: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
This is what's causing bug 1180935.
Blocks: 1180935
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: