Closed
Bug 1173729
Opened 9 years ago
Closed 9 years ago
Update generic close icon and new tab button icon on Windows 10
Categories
(Firefox :: Theme, defect, P1)
Tracking
()
VERIFIED
FIXED
Firefox 42
| Tracking | Status | |
|---|---|---|
| firefox39 | --- | unaffected |
| firefox40 | --- | verified |
| firefox41 | --- | verified |
| firefox42 | --- | verified |
People
(Reporter: dao, Assigned: dao)
References
(Blocks 1 open bug)
Details
Attachments
(9 files, 1 obsolete file)
|
(deleted),
image/png
|
Details | |
|
(deleted),
image/png
|
Details | |
|
(deleted),
image/png
|
Details | |
|
(deleted),
image/png
|
Details | |
|
(deleted),
image/png
|
Details | |
|
(deleted),
image/png
|
Details | |
|
(deleted),
image/png
|
Details | |
|
(deleted),
image/png
|
Details | |
|
(deleted),
patch
|
jaws
:
review+
lmandel
:
approval-mozilla-aurora+
lmandel
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
close-tab-win10.png
Notably, this will make the tab close button larger for touch-friendliness.
|
||
Updated•9 years ago
|
Priority: -- → P1
|
||
Comment 2•9 years ago
|
||
Flags: needinfo?(shorlander)
|
|
||
Comment 3•9 years ago
|
||
|
Assignee | |
Comment 4•9 years ago
|
||
We also need inverted variants.
And we need the new-tab button icons. Let me know if you prefer handling those in a separate bug.
Flags: needinfo?(shorlander)
|
|
||
Comment 5•9 years ago
|
||
Flags: needinfo?(shorlander)
|
|
||
Comment 6•9 years ago
|
||
|
|
||
Comment 7•9 years ago
|
||
|
|
||
Comment 8•9 years ago
|
||
|
|
||
Comment 9•9 years ago
|
||
|
|
||
Comment 10•9 years ago
|
||
|
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → dao
|
|
Assignee | |
Comment 11•9 years ago
|
||
|
|
Assignee | |
Comment 12•9 years ago
|
||
I updated the generic close button, not just the tab close button, since we want touch-friendliness everywhere.
Also made this change on Windows 8 since touch screens are more common there than for older Windows versions.
Attachment #8635241 -
Attachment is obsolete: true
Attachment #8635300 -
Flags: review?(jaws)
|
|
||
Comment 13•9 years ago
|
||
Comment on attachment 8635300 [details] [diff] [review]
patch
Review of attachment 8635300 [details] [diff] [review]:
-----------------------------------------------------------------
untested but the patch looks good. r=me
Attachment #8635300 -
Flags: review?(jaws) → review+
|
|
Assignee | |
Updated•9 years ago
|
Summary: Update tab close button and new tab button icons on Windows 10 → Update generic close icon and new tab button icon on Windows 10
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox42:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
|
|
Assignee | |
Updated•9 years ago
|
Flags: qe-verify+
|
|
Assignee | |
Comment 16•9 years ago
|
||
Comment on attachment 8635300 [details] [diff] [review]
patch
Approval Request Comment
[Feature/regressing bug #]: windows 10
[User impact if declined]: aesthetics and touch-friendliness
[Describe test coverage new/current, TreeHerder]: n/a
[Risks and why]: increasing the icon size for the generic close-icon class is a little bit scary, but this important enough and has baked long enough that we should uplift it
[String/UUID change made/needed]: none
Attachment #8635300 -
Flags: approval-mozilla-beta?
Attachment #8635300 -
Flags: approval-mozilla-aurora?
|
||
Updated•9 years ago
|
status-firefox39:
--- → unaffected
status-firefox40:
--- → affected
|
|
||
Comment 17•9 years ago
|
||
Comment on attachment 8635300 [details] [diff] [review]
patch
This fix has been on m-c for 5 days. Let's get it into beta7 and see if any issues shake out. Beta+ Aurora+
Attachment #8635300 -
Flags: approval-mozilla-beta?
Attachment #8635300 -
Flags: approval-mozilla-beta+
Attachment #8635300 -
Flags: approval-mozilla-aurora?
Attachment #8635300 -
Flags: approval-mozilla-aurora+
|
||
Comment 18•9 years ago
|
||
|
|
||
Comment 19•9 years ago
|
||
|
||
Updated•9 years ago
|
QA Contact: cornel.ionce
|
||
Comment 20•9 years ago
|
||
Confirming this fix on Windows 10 64-bit using:
- latest Nightly, build ID: 20150726030217;
- latest Aurora, build ID: 20150726004010;
- Firefox 40 beta 7, build ID: 20150723165742.
Ran into issue 1185889 on DevEdition.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•