Closed
Bug 1173739
Opened 9 years ago
Closed 9 years ago
Update history dropdown and Reload/Stop/Go icons on Windows 10
Categories
(Firefox :: Theme, defect, P2)
Tracking
()
VERIFIED
FIXED
Firefox 42
Tracking | Status | |
---|---|---|
firefox39 | --- | unaffected |
firefox40 | --- | verified |
firefox41 | --- | verified |
firefox42 | --- | verified |
People
(Reporter: dao, Assigned: dao)
References
(Blocks 1 open bug)
Details
Attachments
(9 files)
(deleted),
image/png
|
Details | |
(deleted),
image/png
|
Details | |
(deleted),
image/png
|
Details | |
(deleted),
image/png
|
Details | |
(deleted),
image/png
|
Details | |
(deleted),
image/png
|
Details | |
(deleted),
image/png
|
Details | |
(deleted),
image/png
|
Details | |
(deleted),
patch
|
jaws
:
review+
lmandel
:
approval-mozilla-aurora+
lmandel
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Updated•9 years ago
|
Summary: Update history dropdown and Reload/Stop/Go icons on Windows 10 → Update history dropdown, Reload/Stop/Go and Search bar search glass icons on Windows 10
Updated•9 years ago
|
Priority: -- → P1
Comment 2•9 years ago
|
||
Dropdown icon like the one on the taskbar?
Comment 3•9 years ago
|
||
Flags: needinfo?(shorlander)
Comment 4•9 years ago
|
||
Comment 5•9 years ago
|
||
Comment 6•9 years ago
|
||
Comment 7•9 years ago
|
||
Comment 8•9 years ago
|
||
Comment 9•9 years ago
|
||
Comment 10•9 years ago
|
||
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → dao
Assignee | ||
Updated•9 years ago
|
Assignee: dao → nobody
Priority: P1 → P2
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → dao
Assignee | ||
Comment 11•9 years ago
|
||
Turns out we currently use the same icon on all OSes. Having one icon for Windows 10 only and another one shared for all the rest (that's other Windows versions, Linux and OS X) seems weird. Spinning this off to bug 1173739.
Summary: Update history dropdown, Reload/Stop/Go and Search bar search glass icons on Windows 10 → Update history dropdown and Reload/Stop/Go icons on Windows 10
Assignee | ||
Comment 12•9 years ago
|
||
Attachment #8635700 -
Flags: review?(jaws)
Comment 13•9 years ago
|
||
Comment on attachment 8635700 [details] [diff] [review]
patch
Makes sense to me to use the new asset for Windows 8 as well. The old glow doesn't really fit into the Windows 8 experience either.
Assignee | ||
Comment 14•9 years ago
|
||
I don't have a strong opinion about whether we should use these images on Windows 8. I don't think it makes a big difference.
Updated•9 years ago
|
Attachment #8635700 -
Flags: review?(jaws) → review+
Assignee | ||
Comment 16•9 years ago
|
||
Please file a new bug if you still think we should use the new icons on Windows 8.
Comment 17•9 years ago
|
||
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox42:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
Assignee | ||
Updated•9 years ago
|
Flags: qe-verify+
Assignee | ||
Comment 18•9 years ago
|
||
Comment on attachment 8635700 [details] [diff] [review]
patch
Approval Request Comment
[Feature/regressing bug #]: windows 10
[User impact if declined]: aesthetics
[Describe test coverage new/current, TreeHerder]: n/a
[Risks and why]: just an image drop, low risk
[String/UUID change made/needed]: none
Attachment #8635700 -
Flags: approval-mozilla-beta?
Attachment #8635700 -
Flags: approval-mozilla-aurora?
Updated•9 years ago
|
status-firefox39:
--- → unaffected
status-firefox40:
--- → affected
Comment 19•9 years ago
|
||
Comment on attachment 8635700 [details] [diff] [review]
patch
Beta+ Aurora+
Attachment #8635700 -
Flags: approval-mozilla-beta?
Attachment #8635700 -
Flags: approval-mozilla-beta+
Attachment #8635700 -
Flags: approval-mozilla-aurora?
Attachment #8635700 -
Flags: approval-mozilla-aurora+
Comment 20•9 years ago
|
||
Comment 21•9 years ago
|
||
Updated•9 years ago
|
QA Contact: cornel.ionce
Comment 22•9 years ago
|
||
The icons are now changed but a small glow can still be noticed on hover/click. Filled bug 1188332 as a follow up.
Tested on Windows 10 64-bit using:
- Nightly 42.0a1, build ID: 20150727030216;
- Aurora 41.0a2, build ID: 20150727004009;
- Firefox 40.0b8, build ID: 20150727174134.
Status: RESOLVED → VERIFIED
Depends on: 1188332
You need to log in
before you can comment on or make changes to this bug.
Description
•