Closed
Bug 1173740
Opened 9 years ago
Closed 9 years ago
Update switch-to-tab icon for the URL bar autocomplete popup on Windows 8 and 10
Categories
(Firefox :: Theme, defect, P3)
Tracking
()
VERIFIED
FIXED
Firefox 42
| Tracking | Status | |
|---|---|---|
| firefox39 | --- | unaffected |
| firefox40 | --- | verified |
| firefox41 | --- | verified |
| firefox42 | --- | verified |
People
(Reporter: dao, Assigned: dao)
References
(Blocks 1 open bug)
Details
Attachments
(3 files)
|
(deleted),
image/png
|
Details | |
|
(deleted),
image/png
|
Details | |
|
(deleted),
patch
|
jaws
:
review+
lmandel
:
approval-mozilla-aurora+
lmandel
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
actionicon-tab-win10.png
No description provided.
|
||
Updated•9 years ago
|
Priority: -- → P1
|
Assignee | |
Comment 2•9 years ago
|
||
This is only a minor icon update in a not particularly prominent place in the UI; seems like a lower priority fix by definition.
Priority: P1 → P3
|
||
Comment 3•9 years ago
|
||
Flags: needinfo?(shorlander)
|
|
||
Updated•9 years ago
|
Attachment #8630539 -
Attachment description: actionicon-tab.png → actionicon-tab-win10.png
Attachment #8630539 -
Attachment filename: actionicon-tab.png → actionicon-tab-win10.png
|
|
||
Comment 4•9 years ago
|
||
|
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → dao
|
|
Assignee | |
Comment 5•9 years ago
|
||
Attachment #8636625 -
Flags: review?(jaws)
|
|
||
Comment 6•9 years ago
|
||
Comment on attachment 8636625 [details] [diff] [review]
patch
Review of attachment 8636625 [details] [diff] [review]:
-----------------------------------------------------------------
actionicon-tab.png should have been renamed to actionicon-tab-XPVista7.png, and then the updated actionicon-tab.png should have been created. As it is right now, the hg history of this file isn't going to match the real history of the file.
Attachment #8636625 -
Flags: review?(jaws) → review+
|
|
Assignee | |
Updated•9 years ago
|
Flags: qe-verify+
Summary: Update switch-to-tab icon for the URL bar autocomplete popup on Windows 10 → Update switch-to-tab icon for the URL bar autocomplete popup on Windows 8 and 10
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox42:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
|
|
Assignee | |
Comment 9•9 years ago
|
||
Comment on attachment 8636625 [details] [diff] [review]
patch
Approval Request Comment
[Feature/regressing bug #]: windows 10
[User impact if declined]: aesthetics
[Describe test coverage new/current, TreeHerder]: n/a
[Risks and why]: straightforward CSS patch, low risk
[String/UUID change made/needed]: none
Attachment #8636625 -
Flags: approval-mozilla-beta?
Attachment #8636625 -
Flags: approval-mozilla-aurora?
|
||
Updated•9 years ago
|
status-firefox39:
--- → unaffected
status-firefox40:
--- → affected
|
|
||
Comment 10•9 years ago
|
||
Comment on attachment 8636625 [details] [diff] [review]
patch
As per the bug summary, this change does impact Windows 8 as well. We should verify the change on both Win8 and Win10. Beta+ Aurora+
Attachment #8636625 -
Flags: approval-mozilla-beta?
Attachment #8636625 -
Flags: approval-mozilla-beta+
Attachment #8636625 -
Flags: approval-mozilla-aurora?
Attachment #8636625 -
Flags: approval-mozilla-aurora+
|
||
Comment 11•9 years ago
|
||
|
|
||
Comment 12•9 years ago
|
||
|
||
Updated•9 years ago
|
QA Contact: cornel.ionce
|
||
Comment 13•9 years ago
|
||
Reproduced this issue with Firefox 40 beta 6.
Confirming the fix on WIndows 8.1 32-bit and Windows 10 64-bit using:
- latest Nightly, build ID: 20150723030207;
- latest Aurora, build ID: 20150723004007;
- Firefox 40 beta 7, build ID: 20150723165742.
Also verified using a Microsoft Surface Pro 2 device.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•