Closed
Bug 1174111
Opened 9 years ago
Closed 9 years ago
|test_sendTimeout| in test_TelemetryControllerShutdown.js must not wait on ping submission
Categories
(Toolkit :: Telemetry, defect)
Toolkit
Telemetry
Tracking
()
RESOLVED
FIXED
mozilla41
| Tracking | Status | |
|---|---|---|
| firefox41 | --- | fixed |
People
(Reporter: Dexter, Assigned: Dexter)
References
Details
(Whiteboard: [b5] [unifiedTelemetry])
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
Dexter
:
review+
|
Details | Diff | Splinter Review |
In |test_sendTimeout| (test_TelemetryControllerShutdown.js) [1] we wait on the ping submission before triggering the phase change/shutdown.
This makes the test take a lot of time and possibly never fail. We should be waiting on the submission promise after the AsyncShutdown phases are manually triggered.
[1] - https://hg.mozilla.org/mozilla-central/annotate/8cf9d3e497f9/toolkit/components/telemetry/tests/unit/test_TelemetryControllerShutdown.js#l64
|
Assignee | |
Comment 1•9 years ago
|
||
Assignee: nobody → alessio.placitelli
Status: NEW → ASSIGNED
Attachment #8621509 -
Flags: review?(gfritzsche)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8621509 [details] [diff] [review]
bug1174111.patch
Review of attachment 8621509 [details] [diff] [review]:
-----------------------------------------------------------------
::: toolkit/components/telemetry/tests/unit/test_TelemetryControllerShutdown.js
@@ +65,5 @@
>
> // Trigger the AsyncShutdown phase TelemetryController hangs off.
> AsyncShutdown.profileBeforeChange._trigger();
> AsyncShutdown.sendTelemetry._trigger();
> + yield submissionPromise;
Nit: Lets put a new comment before that like "Now wait for the ping submission."
Attachment #8621509 -
Flags: review?(gfritzsche) → review+
|
|
Assignee | |
Comment 3•9 years ago
|
||
Thanks Georg. Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=efc5c1c0cca5
Attachment #8621509 -
Attachment is obsolete: true
Attachment #8621512 -
Flags: review+
|
||
Comment 5•9 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
|
|
||
Updated•9 years ago
|
Whiteboard: [uplift]
|
|
||
Updated•9 years ago
|
Whiteboard: [uplift] → [uplift2]
|
|
||
Updated•9 years ago
|
Whiteboard: [uplift2] → [b5] [unifiedTelemetry] [uplift2]
|
|
||
Updated•9 years ago
|
Whiteboard: [b5] [unifiedTelemetry] [uplift2] → [b5] [unifiedTelemetry]
You need to log in
before you can comment on or make changes to this bug.
Description
•