Closed Bug 1174244 Opened 9 years ago Closed 9 years ago

Switch in-tree Adjust SDK to use ch.boye instead of org.apache.http to allow for building with Android M SDK 23

Categories

(Firefox for Android Graveyard :: General, defect, P1)

Product:
Firefox for Android Graveyard
Component:
General
Type:
defect

Tracking

(firefox44 fixed, fennec44+)

Status:
RESOLVED FIXED
Milestone:
Firefox 44
Tracking Flags:
Tracking Status
firefox44 --- fixed
fennec 44+ ---

People

(Reporter: amoghbl1, Assigned: nalexander)

References

Details

(Whiteboard: [tor-mobile])

Attachments

(1 file, 1 obsolete file)

MozReview Request: Bug 1174244 - Switch in-tree Adjust SDK to use ch.boye instead of org.apache.http. r?sebastian
(deleted), text/x-review-board-request
sebastian
: review+
Details
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:40.0) Gecko/20100101 Firefox/40.0 Build ID: 20150610004004
The third party lib com.adjust.sdk used deprecated (as of android M) networking libraries and would therefore fail.
Component: Untriaged → General
Product: Firefox → Firefox for Android
Version: 34 Branch → unspecified
This should have happened with Bug 1169421. Nominating for tracking since Fennec builds are going to burn when the Android SDK 23 (Bug build-android-m) changes hit release.
Status: UNCONFIRMED → NEW
tracking-fennec: --- → ?
Depends on: 1169421, build-android-m
Ever confirmed: true
Summary: com.adjust.sdk won't build with android m → Switch in-tree Adjust SDK to use ch.boye instead of org.apache.http to allow for building with Android M SDK 23
Oh, this has been totally out of sight for me. It looks like this has been addressed on GitHub: https://github.com/adjust/android_sdk/commit/a9eec419ee7e2bc26424032b9023b25582dea1d9 Are we using the SDK as-is and can "just" update it or have we made modifications?
(In reply to Sebastian Kaspari (:sebastian) from comment #3) > Oh, this has been totally out of sight for me. > > It looks like this has been addressed on GitHub: > https://github.com/adjust/android_sdk/commit/ > a9eec419ee7e2bc26424032b9023b25582dea1d9 > > Are we using the SDK as-is and can "just" update it or have we made > modifications? We should be using it as-is. We just wanted a known revision in the tree.
(In reply to Mark Finkle (:mfinkle) from comment #4) > (In reply to Sebastian Kaspari (:sebastian) from comment #3) > > Oh, this has been totally out of sight for me. > > > > It looks like this has been addressed on GitHub: > > https://github.com/adjust/android_sdk/commit/ > > a9eec419ee7e2bc26424032b9023b25582dea1d9 > > > > Are we using the SDK as-is and can "just" update it or have we made > > modifications? > > We should be using it as-is. We just wanted a known revision in the tree. I thought we fixed some NPEs in our local tree, but I can't guarantee. We should consider updating the upstream SDK while we address this. The original fx-team commit message includes an upstream git commit SHA, so we can see changes.
Bug 1174244 - Switch in-tree Adjust SDK to use ch.boye instead of org.apache.http. r?sebastian
Attachment #8676442 - Flags: review?(s.kaspari)
Bug 1174244 - Remove 'thirdparty_adjust_sdk' Gradle project. r?sebastian
Attachment #8676443 - Flags: review?(s.kaspari)
Comment on attachment 8676442 [details] MozReview Request: Bug 1174244 - Switch in-tree Adjust SDK to use ch.boye instead of org.apache.http. r?sebastian Bug 1174244 - Switch in-tree Adjust SDK to use ch.boye instead of org.apache.http. r?sebastian
Attachment #8676443 - Attachment is obsolete: true
Attachment #8676443 - Flags: review?(s.kaspari)
Comment on attachment 8676442 [details] MozReview Request: Bug 1174244 - Switch in-tree Adjust SDK to use ch.boye instead of org.apache.http. r?sebastian https://reviewboard.mozilla.org/r/22711/#review20307 Thanks! That's easier than migrating to URLConnection I guess. :)
Attachment #8676442 - Flags: review?(s.kaspari) → review+
Assignee: nobody → nalexander
https://hg.mozilla.org/mozilla-central/rev/396f9bde9b49 https://hg.mozilla.org/mozilla-central/rev/ef1e7dec5bad
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox44: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
tracking-fennec: ? → 44+
I missed a dependency with this patch, and didn't catch it in my testing. The result is Bug 1232468 -- sorry, releng team.
Blocks: 1232468
Whiteboard: [tor-mobile]
Blocks: 1357994
Priority: -- → P1
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: