Closed
Bug 1174367
Opened 9 years ago
Closed 9 years ago
Remove the #xywh code from shared/js/media/crop_resize_rotate.js
Categories
(Firefox OS Graveyard :: Gaia::Shared, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: djf, Assigned: djf)
Details
Attachments
(1 file)
The #xywh media fragment has never actually worked, apparently. So I should remove the code in the cropResizeRotate() utility that attempts to use it.
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → dflanagan
|
|
Assignee | |
Comment 1•9 years ago
|
||
Punam,
I think that crop_resize_rotate.js is only being used by the Gallery app, so I'm asking for your review of this patch. This removes the code that attempts to use the #xywh media fragment. It turns out that it has never worked, and images were always being decoded fullsize rather than pre-cropped, so removing the code doesn't change anything it just makes our code simpler.
There's no rush on this review.
Attachment #8623923 -
Flags: review?(pdahiya)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8623923 [details]
link to patch on github
Hi David
Patch looks good and has my r+. One nit left in github about removing not needed comment and with that updated patch looks good to land. Thanks!
Attachment #8623923 -
Flags: review?(pdahiya) → review+
|
|
Assignee | |
Comment 3•9 years ago
|
||
Landed to master: https://github.com/mozilla-b2g/gaia/commit/816c360ba59c009a97c7f20742fb1b34426d27db
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•